Skip to content

Standarize map names across info and manifest jsons#4011

Merged
evanpelle merged 2 commits into
openfrontio:mainfrom
RickD004:infoformat
May 27, 2026
Merged

Standarize map names across info and manifest jsons#4011
evanpelle merged 2 commits into
openfrontio:mainfrom
RickD004:infoformat

Conversation

@RickD004
Copy link
Copy Markdown
Contributor

Description:

Just a text change. 4 maps had inconsistencies in their names in their info.json (and by consequence the manifest). If sites extracted map names from one of these they would appear with an inconsistent name. The south america map for example was named "Americas", and appeared as such in the pathfinding playground (thats where i noticed these inconsistencies)

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aa4d2e45-c183-40cb-8e61-938c16a30a29

📥 Commits

Reviewing files that changed from the base of the PR and between 2d6342c and 33a21e7.

📒 Files selected for processing (8)
  • map-generator/assets/maps/bajacalifornia/info.json
  • map-generator/assets/maps/greatlakes/info.json
  • map-generator/assets/maps/milkyway/info.json
  • map-generator/assets/maps/southamerica/info.json
  • resources/maps/bajacalifornia/manifest.json
  • resources/maps/greatlakes/manifest.json
  • resources/maps/milkyway/manifest.json
  • resources/maps/southamerica/manifest.json

Walkthrough

This PR normalizes map display names across the map asset and resource pipeline. Asset metadata files in map-generator/assets/maps/*/info.json and corresponding manifest files in resources/maps/*/manifest.json are updated to use properly cased names instead of lowercase identifiers or generic labels.

Changes

Map Display Name Normalization

Layer / File(s) Summary
Asset metadata name normalization
map-generator/assets/maps/bajacalifornia/info.json, map-generator/assets/maps/greatlakes/info.json, map-generator/assets/maps/milkyway/info.json, map-generator/assets/maps/southamerica/info.json
Map asset metadata names updated from lowercase formats ("bajacalifornia", "greatlakes", "milkyway") and generic labels ("Americas") to properly cased display names: "Baja California", "Great Lakes", "Milky Way", and "South America".
Resource manifest name normalization
resources/maps/bajacalifornia/manifest.json, resources/maps/greatlakes/manifest.json, resources/maps/milkyway/manifest.json, resources/maps/southamerica/manifest.json
Map manifest names synchronized to match asset metadata updates with the same properly cased display names across all four regions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openfrontio/OpenFrontIO#3914: Updates map display metadata name casing in map-generator/assets/maps/*/info.json files similarly to this PR.

Suggested reviewers

  • evanpelle
  • FloPinguin

📍 Maps now wear their proper names with pride,
From data files to manifests, they shine with style,
Baja California, Great Lakes, Milky Way ride,
South America takes its place with a smile! ✨🗺️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: standardizing map names across info.json and manifest.json files for four maps.
Description check ✅ Passed The description is directly related to the changeset, explaining the naming inconsistencies and providing a concrete example (South America map named 'Americas').
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@evanpelle evanpelle added this to the v32 milestone May 27, 2026
Copy link
Copy Markdown
Collaborator

@evanpelle evanpelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@github-project-automation github-project-automation Bot moved this from Triage to Final Review in OpenFront Release Management May 27, 2026
@evanpelle evanpelle merged commit 1551de8 into openfrontio:main May 27, 2026
12 of 13 checks passed
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management May 27, 2026
@RickD004 RickD004 deleted the infoformat branch May 27, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants