Add May Labyrinth#4002
Conversation
Add raw files labyrinth
Rendered labyrinth files
updated en.json
Updated Game.ts
Updated MapPlaylist.ts
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds a new playable map "Labyrinth": registers the map type and category, supplies full map asset/manifest (nations and spawn areas), updates playlist weighting, and adds an English localization entry. ChangesLabyrinth Map Addition
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/core/game/Game.ts`:
- Line 179: Add a unit test that verifies GameMapType.Labyrinth is registered
and present in the arcade category: import GameMapType and mapCategories, assert
that GameMapType.Labyrinth exists on the enum/collection and assert
mapCategories.arcade includes GameMapType.Labyrinth (or its string value), using
the project test framework's existing pattern for core map/category tests so the
test runs under the same suite as other src/core/ tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bfb148e2-5d92-4520-9c15-4b32db1a4ebb
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/labyrinth/image.pngis excluded by!**/*.pngresources/maps/labyrinth/map.binis excluded by!**/*.binresources/maps/labyrinth/map16x.binis excluded by!**/*.binresources/maps/labyrinth/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (6)
map-generator/assets/maps/labyrinth/info.jsonresources/lang/en.jsonresources/maps/labyrinth/manifest.jsonresources/maps/labyrinth/thumbnail.webpsrc/core/game/Game.tssrc/server/MapPlaylist.ts
|
Please recheck files. Map files were uploaded to map-gen folder 3hr ago, but folder did not update until recently. |
updated main.go
Description:
Labyrinth is a maze type map. My attempt at making a more chess style board for play. Games with bots appear stable at over 45min average run times. The map has been setup for team spawn zones for 2, 3, 4, 5, 6, and 7 teams. Some of the team spawns for odd numbers are experimental and I would like to see how they play out with live players. Additional nation names included. There are other design factors like each of the large squares being within the blast radius of a hydro; small islands are within the blast radius of nukes.
This is meant as a slower playing game. My intentions are to get some sort of literal rotation of the map in the future if easily implemented. That way every time players load the game there would be some randomization.
As an additional note one of my last edit to the map was the "+" shape to the islands to allow train passage. Zooming out I can see now that the pattern is squares and + through out. Did not fully intend on that, but it felt like good vibes.
https://discord.com/channels/1284581928254701718/1293201128858587207/threads/1497062552784605316
https://www.youtube.com/watch?v=e8c-TylT4hs
https://www.youtube.com/watch?v=0-yqrfr3nv0
Please complete the following:
Please put your Discord username
PlaysBadly