Skip to content

Support plugin vdW interactions without electrostatics#695

Merged
mattwthompson merged 3 commits into
mainfrom
fix-694
May 1, 2023
Merged

Support plugin vdW interactions without electrostatics#695
mattwthompson merged 3 commits into
mainfrom
fix-694

Conversation

@mattwthompson

Copy link
Copy Markdown
Member

Description

This PR fixes an assumption in the OpenMM export logic that a vdW collection exists with that name as a non-plugin.

Checklist

  • Test in Evaluator test environment
  • Add tests
  • Lint
  • Update docstrings

@codecov

codecov Bot commented May 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #695 (5f5f720) into main (c7b9c6d) will increase coverage by 0.63%.
The diff coverage is 100.00%.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review May 1, 2023 19:54
@mattwthompson

Copy link
Copy Markdown
Member Author

This is needed for openforcefield/openff-evaluator#512 but something else is also needed.

@mattwthompson mattwthompson merged commit 83f0677 into main May 1, 2023
@mattwthompson mattwthompson changed the title FIX: Do not assume vdW handler exists Support plugin vdW interactions without electrostatics May 2, 2023
@mattwthompson mattwthompson deleted the fix-694 branch August 25, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant