DP-1.2: Updated state path validation for classifer interface binding#5611
DP-1.2: Updated state path validation for classifer interface binding#5611charantejag504 wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the state path validation for classifier interface binding within the QoS policy configuration tests. By shifting the telemetry verification to target the interface logical unit, the test suite ensures more accurate binding validation for classifier configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5611 / 81ccc02Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request updates the testJuniperClassifierConfig function in qos_policy_config_test.go to construct a logical interface name (using the format interface.subinterface) instead of using the physical port name directly when verifying the applied QoS classifier. Additionally, the copyright year was updated to 2026 and the fmt package was imported. There are no review comments, so I have no feedback to provide.
Updated state path to export Classifier Interface logical unit binding