Skip to content

DP-1.2: Updated state path validation for classifer interface binding#5611

Open
charantejag504 wants to merge 1 commit into
openconfig:mainfrom
charantejag504:DP-1.2-BINDING-FIX
Open

DP-1.2: Updated state path validation for classifer interface binding#5611
charantejag504 wants to merge 1 commit into
openconfig:mainfrom
charantejag504:DP-1.2-BINDING-FIX

Conversation

@charantejag504

Copy link
Copy Markdown
Contributor

Updated state path to export Classifier Interface logical unit binding

@charantejag504 charantejag504 requested a review from a team as a code owner June 23, 2026 18:13
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the state path validation for classifier interface binding within the QoS policy configuration tests. By shifting the telemetry verification to target the interface logical unit, the test suite ensures more accurate binding validation for classifier configurations.

Highlights

  • Telemetry Path Update: Updated the QoS classifier telemetry path to reference the interface logical unit instead of the physical interface name.
  • Test Configuration: Introduced a subinterface index and formatted the interface logical unit string to support the updated telemetry validation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

Copy link
Copy Markdown

Pull Request Functional Test Report for #5611 / 81ccc02

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
DP-1.2: QoS policy feature config
Cisco 8000E status
DP-1.2: QoS policy feature config
Cisco XRd status
DP-1.2: QoS policy feature config
Juniper ncPTX status
DP-1.2: QoS policy feature config
Nokia SR Linux status
DP-1.2: QoS policy feature config
Openconfig Lemming status
DP-1.2: QoS policy feature config

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
DP-1.2: QoS policy feature config
Cisco 8808 status
DP-1.2: QoS policy feature config
Juniper PTX10008 status
DP-1.2: QoS policy feature config
Nokia 7250 IXR-10e status
DP-1.2: QoS policy feature config

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the testJuniperClassifierConfig function in qos_policy_config_test.go to construct a logical interface name (using the format interface.subinterface) instead of using the physical port name directly when verifying the applied QoS classifier. Additionally, the copyright year was updated to 2026 and the fmt package was imported. There are no review comments, so I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants