TE-16.3: Accept valid alternate outerIP for test-4 backup route#5609
TE-16.3: Accept valid alternate outerIP for test-4 backup route#5609karthikeya-remilla wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the traffic encapsulation validation logic to support an alternate outer IP address for the Test-4 backup route, ensuring that both valid encapsulation paths are correctly recognized during testing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the traffic encapsulation validation in encap_frr_with_reencap_vrf_test.go to allow an alternative outer destination IP (gribiIPv4EntryVRF2225) for the TE-16.3 backup case. The reviewer suggested simplifying the boolean logic for checking the allowed outer destination IP and improving the error message to more accurately reflect that the outer destination IP is incorrect rather than stating the packets are not encapsulated.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Moving to draft till bug discussion for TE-16.3 is resolved offline. |
3 participants
Modified validateTrafficEncap to accept gribiIPv4EntryVRF2225 as a valid outer IP alternative whenever it expects gribiIPv4EntryVRF2222, since both are completely valid encapsulations for that port under Test-4's backup route.