Skip to content

Update scale requirements in README.md#5607

Open
paramasivamn1 wants to merge 4 commits into
mainfrom
paramasivamn1-patch-3
Open

Update scale requirements in README.md#5607
paramasivamn1 wants to merge 4 commits into
mainfrom
paramasivamn1-patch-3

Conversation

@paramasivamn1

Copy link
Copy Markdown
Contributor

Update scale requirements in README.md

@paramasivamn1 paramasivamn1 requested a review from a team as a code owner June 22, 2026 03:59
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the scale testing parameters and documentation within the AFT prefix filtering resilience test suite. The changes ensure that the test environment documentation aligns with current scale requirements and provides more accurate guidance on prefix filtering and collector verification.

Highlights

  • Scale Requirements Update: Increased the default number of IPv4 and IPv6 routes for scale testing in the README to 1,500,000 and 500,000 respectively.
  • Documentation Clarification: Updated prefix-set configuration details and clarified verification steps for gNMI collectors to better reflect expected behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the scale test parameters and routing policy details in the README.md for the AFT prefix filtering resilience test, significantly increasing the default IPv4 and IPv6 route scale and clarifying prefix-set configurations. The review feedback highlights several grammatical issues in the updated documentation, such as awkward phrasing, incorrect verb agreement ('Matches includes'), and a duplicate word ('of of').

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

next-hops are received normally. Verify `100.64.0.0/24` is **not** received.

- Collector 2: Verify `SYNC` and receipt of only `100.64.1.0/24` from `VRF-A`.
- Collector 2: Verify `SYNC` and receipt of of allowed prefixes including `100.64.1.0/24` from `VRF-A`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a duplicate 'of' in 'receipt of of allowed prefixes'. It should be 'receipt of allowed prefixes'.

References
  1. Ensure correct grammar, including subject-verb agreement and proper use of singular/plural forms.

paramasivamn1 and others added 3 commits June 22, 2026 13:24
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants