PF-1.1 : match_dscp_indirect_next_hop_test.go : refactor dscp values as a set

[sudhirakondi]

Refactor the DSCP matching rules to use SetDscpSet and configure interface references.

[OpenConfigBot]

Pull Request Functional Test Report for #5589 / 9d42436

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		PF-1.1: IPv4/IPv6 policy-forwarding to indirect NH matching DSCP/TC.
Cisco 8000E		PF-1.1: IPv4/IPv6 policy-forwarding to indirect NH matching DSCP/TC.
Cisco XRd		PF-1.1: IPv4/IPv6 policy-forwarding to indirect NH matching DSCP/TC.
Juniper ncPTX		PF-1.1: IPv4/IPv6 policy-forwarding to indirect NH matching DSCP/TC.
Nokia SR Linux		PF-1.1: IPv4/IPv6 policy-forwarding to indirect NH matching DSCP/TC.
Openconfig Lemming		PF-1.1: IPv4/IPv6 policy-forwarding to indirect NH matching DSCP/TC.

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		PF-1.1: IPv4/IPv6 policy-forwarding to indirect NH matching DSCP/TC.
Cisco 8808		PF-1.1: IPv4/IPv6 policy-forwarding to indirect NH matching DSCP/TC.
Juniper PTX10008		PF-1.1: IPv4/IPv6 policy-forwarding to indirect NH matching DSCP/TC.
Nokia 7250 IXR-10e		PF-1.1: IPv4/IPv6 policy-forwarding to indirect NH matching DSCP/TC.

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the DSCP matching logic within the policy forwarding test suite to improve efficiency and alignment with current configuration standards. It replaces iterative rule creation with a set-based approach and ensures that network instances and interface references are explicitly defined, enhancing the robustness of the test environment setup.

Highlights

• DSCP Matching Refactor: Updated the traffic policy configuration to use SetDscpSet instead of individual rule iterations for DSCP matching.
• Interface Reference Configuration: Added explicit interface reference configuration, including interface and subinterface settings, to the policy forwarding interface.
• Network Instance Updates: Explicitly set the network instance type to default for both policy forwarding and BGP neighbor configurations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the policy forwarding configuration in the DSCP match test to use a single rule with SetDscpSet for IPv4 and IPv6 instead of creating multiple rules in a loop. It also configures the network instance type and interface references. The review feedback suggests simplifying the IPv6 rule ID to 2 now that the loop is removed, and guarding the interface reference configuration with the InterfaceRefConfigUnsupported deviation to ensure multi-vendor compatibility.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.