Update hold-time down timer from 2000 to 5000#5583
Conversation
For TC5 Short-Down, 2000ms is very aggressive as LOS recovery may not happen within 2sec.
Pull Request Functional Test Report for #5583 / 27d8451Virtual Devices
Hardware Devices
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the hold-down timer configuration for the TC5 Short-Down test case. The previous value was found to be too aggressive, potentially causing test failures due to insufficient time for LOS (Loss of Signal) recovery. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the down hold-time configuration value from 2000 to 5000 in the TestTC5ShortDOWN test within holddown_timers_test.go. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
For TC5 Short-Down, 2000ms is very aggressive as LOS recovery may not happen within 2sec.