Skip to content

Update hold-time down timer from 2000 to 5000#5583

Open
ameya-kadam wants to merge 1 commit into
openconfig:mainfrom
ameya-kadam:patch-1
Open

Update hold-time down timer from 2000 to 5000#5583
ameya-kadam wants to merge 1 commit into
openconfig:mainfrom
ameya-kadam:patch-1

Conversation

@ameya-kadam

Copy link
Copy Markdown

For TC5 Short-Down, 2000ms is very aggressive as LOS recovery may not happen within 2sec.

For TC5 Short-Down, 2000ms is very aggressive as LOS recovery may not happen within 2sec.
@ameya-kadam ameya-kadam requested a review from a team as a code owner June 16, 2026 20:55
@OpenConfigBot

Copy link
Copy Markdown

Pull Request Functional Test Report for #5583 / 27d8451

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-5.5: Interface hold-time
Cisco 8000E status
RT-5.5: Interface hold-time
Cisco XRd status
RT-5.5: Interface hold-time
Juniper ncPTX status
RT-5.5: Interface hold-time
Nokia SR Linux status
RT-5.5: Interface hold-time
Openconfig Lemming status
RT-5.5: Interface hold-time

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-5.5: Interface hold-time
Cisco 8808 status
RT-5.5: Interface hold-time
Juniper PTX10008 status
RT-5.5: Interface hold-time
Nokia 7250 IXR-10e status
RT-5.5: Interface hold-time

Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the hold-down timer configuration for the TC5 Short-Down test case. The previous value was found to be too aggressive, potentially causing test failures due to insufficient time for LOS (Loss of Signal) recovery.

Highlights

  • Timer Adjustment: Increased the hold-down timer from 2000ms to 5000ms in the TC5 Short-Down test case to accommodate slower LOS recovery times.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the down hold-time configuration value from 2000 to 5000 in the TestTC5ShortDOWN test within holddown_timers_test.go. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants