Add deviation for SubinterfacePacketCountersMissing in Juniper#5578
Add deviation for SubinterfacePacketCountersMissing in Juniper#5578priyaranjannanda wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new deviation, SubinterfacePacketCountersMissing, to accommodate Juniper hardware that does not support subinterface packet counters. By updating the configuration metadata and adding a conditional skip in the relevant test suite, the change ensures that health checks remain robust and avoid false failures on affected platforms. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5578 / 9d84445Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new deviation 'subinterface_packet_counters_missing' to skip subinterface packet counter tests when the deviation is enabled. The reviewer pointed out that calling 't.Skipf' directly within the 'subIntf' subtest will skip the entire subinterface test, obscuring other successful subtests like 'OperStatus', 'AdminStatus', and 'Description'. They suggested moving the deviation check inside the individual counter subtests or wrapping them in a nested 't.Run' block to ensure accurate test reporting.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The implementation will now skip all subinterface packet counter tests (InDiscards, InErrors, InMulticastPkts, OutDiscards, OutErrors, InFcsErrors) for Juniper, preventing the observed failures.