Skip to content

Add deviation for SubinterfacePacketCountersMissing in Juniper#5578

Open
priyaranjannanda wants to merge 1 commit into
openconfig:mainfrom
priyaranjannanda:Health-1.1_1
Open

Add deviation for SubinterfacePacketCountersMissing in Juniper#5578
priyaranjannanda wants to merge 1 commit into
openconfig:mainfrom
priyaranjannanda:Health-1.1_1

Conversation

@priyaranjannanda

@priyaranjannanda priyaranjannanda commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

The implementation will now skip all subinterface packet counter tests (InDiscards, InErrors, InMulticastPkts, OutDiscards, OutErrors, InFcsErrors) for Juniper, preventing the observed failures.

@priyaranjannanda priyaranjannanda requested a review from a team as a code owner June 15, 2026 16:12
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new deviation, SubinterfacePacketCountersMissing, to accommodate Juniper hardware that does not support subinterface packet counters. By updating the configuration metadata and adding a conditional skip in the relevant test suite, the change ensures that health checks remain robust and avoid false failures on affected platforms.

Highlights

  • Added platform deviation: Included the subinterface_packet_counters_missing flag in the platform exceptions configuration to support Juniper devices.
  • Updated test logic: Modified the system health check tests to skip subinterface packet counter verification when the new deviation is active.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

Copy link
Copy Markdown

Pull Request Functional Test Report for #5578 / 9d84445

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
Health-1.1: Generic Health Check
Cisco 8000E status
Health-1.1: Generic Health Check
Cisco XRd status
Health-1.1: Generic Health Check
Juniper ncPTX status
Health-1.1: Generic Health Check
Nokia SR Linux status
Health-1.1: Generic Health Check
Openconfig Lemming status
Health-1.1: Generic Health Check

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
Health-1.1: Generic Health Check
Cisco 8808 status
Health-1.1: Generic Health Check
Juniper PTX10008 status
Health-1.1: Generic Health Check
Nokia 7250 IXR-10e status
Health-1.1: Generic Health Check

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new deviation 'subinterface_packet_counters_missing' to skip subinterface packet counter tests when the deviation is enabled. The reviewer pointed out that calling 't.Skipf' directly within the 'subIntf' subtest will skip the entire subinterface test, obscuring other successful subtests like 'OperStatus', 'AdminStatus', and 'Description'. They suggested moving the deviation check inside the individual counter subtests or wrapping them in a nested 't.Run' block to ensure accurate test reporting.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants