Repository navigation
Type-check send receipt cases in the static egress suite - #6763
freeqaz-openai wants to merge 3 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR moves six static-egress receipt cases into TypeScript and replaces capacity-test receipt stubs with the real in-memory receipt store. Example: An exchange is cancelled while receipt authorization is paused.
Review scores
ProductKind: Test only · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR provides useful test type coverage, and no actionable defect was found in the introduced changes. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe static-egress suite exercises OCC credential resolution, send authorization, and response receipts through in-process authorities and synthetic loopback providers. flowchart LR
A[JavaScript test registration] --> B[Typed receipt cases]
B --> C[Credential Proxy]
C --> D[Send receipt owner]
D --> E[In-memory platform state]
B --> F[Synthetic loopback provider]
Technical reviewBest possible solution: Retain the typed cases and real in-memory receipt operations, then land through the normal workflow when the author considers the draft ready. Do we have a high-confidence way to reproduce the issue? This test-only PR reports no runtime bug requiring reproduction; source inspection confirms that current main still contains the untyped receipt bodies. Is this the best way to solve the issue? The extraction preserves registration order and scenario assertions while making receipt fields and fault injection typechecked through the existing test project. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against b21aafafd0a2. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 20, 2026, 10:32 AM ET / 15:32 UTC. |
Move six send receipt test bodies into TypeScript so the strict test project checks the receipt fields, transaction faults, and assertions together.
static-egress.test.mjsstill registers each case in its original position.The capacity test now pauses operations on the in-memory receipt store and checks that a cancelled or denied exchange holds its slot until the pending work settles. The persistence cases distinguish a write failure from a lost acknowledgment after commit. They check replay refusal after restart and when a provider rejection fences the affected credential version.
Verification
bd4d02d7,pnpm typecheck,pnpm lint,pnpm format:check, andpnpm check:workspacepassed.mainat39f03946, the strict build and focusedchecks-baseline-1run passed. All 76 cases intests/integration/static-egress.test.mjspassed in their original order, with zero skips and successful cleanup.The focused run uses an in-process authority, in-memory transactions, and a synthetic provider on loopback. Its persistence checks cover the in-memory adapter.