fix: treat failing commit statuses and pending checks as preflight blockers

[SebTardif]

External merge preflight can clear a pull request whose required commit status is red, or whose checks are still running.

From reading scripts/preflight-external-pr-merge.mjs and from node --test --test-name-pattern "legacy status|pending checks" test/preflight-external-pr-merge.test.mjs. This was not reproduced against a live pull request.

isFailingCheck counted a rollup entry as failing only when status was COMPLETED or SUCCESS and conclusion was a non-passing value. A GitHub status context uses state (FAILURE, ERROR, PENDING) and has no conclusion. An in-progress CheckRun uses IN_PROGRESS. Both returned false. isAcceptableMergeState then accepted UNSTABLE, BLOCKED, or BEHIND when mergeable was MERGEABLE, and an empty blocker list continued into security_status: "cleared".

apply-result.mjs validateStatusChecks already blocks FAILURE / ERROR states and pending checks. The inventory copy of isFailingCheck in scripts/import-github-pr-inventory.mjs had the same predicate.

The fork branch treats only SUCCESS, and COMPLETED with a passing conclusion (SUCCESS, SKIPPED, NEUTRAL), as clean. Ignored checks stay ignored.

Upstream pull requests are limited to collaborators (pull_request_creation_policy is collaborators_only), so the patch is on the fork:

• Compare: https://github.com/openclaw/clownfish/compare/main...SebTardif:fix/failing-check-status?expand=1
• Commit: cab1ac31f4d60581b0b57a6e4f13555eb91026a5
• Branch: SebTardif:fix/failing-check-status

[clawsweeper]

Codex review: this still needs some work. Reviewed October 3, 2026, 2:48 AM ET / 06:48 UTC.

Summary
The defect remains on current main. #341 explicitly owns the fix and preserves contributor credit; keep this issue open until that implementation merges.

Reproducibility: yes. source inspection establishes that non-ignored legacy FAILURE/ERROR/PENDING statuses and IN_PROGRESS runs bypass both predicates. No live reproduction or test execution was performed in this read-only review.

Next step
Review and land or close #341 before considering another repair; the open implementation already owns this work.

Review details

Best possible solution:

Use one consistent passing-status rule across preflight and inventory, retaining ignored-check exceptions and the applicator's independent live validation.

Do we have a high-confidence way to reproduce the issue?

Yes, source inspection establishes that non-ignored legacy FAILURE/ERROR/PENDING statuses and IN_PROGRESS runs bypass both predicates. No live reproduction or test execution was performed in this read-only review.

Is this the best way to solve the issue?

Yes, correcting the two predicates is a focused repair of existing check gating; the linked implementation already includes that direction.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 3dd3e22ca0d4.

Label changes

Label changes:

No label changes.

Label justifications:

• P2: Preflight and inventory misclassify failing or unfinished checks, while independent applicator validation limits the demonstrated impact.
• impact:other: The issue affects automation candidate selection and merge-readiness reporting.

Evidence reviewed

What I checked:

• Current-main defect: The predicate only rejects completed or successful statuses with a non-passing conclusion. Legacy FAILURE, ERROR, and PENDING statuses and IN_PROGRESS check runs therefore escape rejection. The blocker collector uses this predicate, and the merge-state helper accepts MERGEABLE UNSTABLE, BLOCKED, or BEHIND candidates when it reports no failing checks. (scripts/preflight-external-pr-merge.mjs:2378, 3dd3e22ca0d4)
• Inventory has the same predicate: Ready-PR filtering also uses the incomplete predicate, so the report identifies two concrete affected production paths. (scripts/import-github-pr-inventory.mjs:720, 3dd3e22ca0d4)
• Existing live-merge safeguard: Applicator validation already rejects FAILURE and ERROR and blocks other unfinished statuses unless expressly allowed; this limits the demonstrated defect to upstream preflight and inventory classification rather than proving an unsafe merge occurred. (scripts/apply-result.mjs:2735, 3dd3e22ca0d4)
• Open implementation owns the work: Live GitHub confirms fix(merge): require confirmed merges and passing preflight checks #341 remains open and unmerged at the recorded head. Its body explicitly closes this issue, describes rejecting legacy failing/error/pending statuses and unfinished runs, and credits SebTardif's patches and diagnosis. (5b3e6bc4895b)
• Default branch and release check: The live default-branch SHA matches the inspected checkout. GitHub's releases endpoint returns no published releases; no shipped fix is established. (3dd3e22ca0d4)
• Area routing history: File history and GitHub commit metadata identify steipete and vincentkoc as recent contributors to the relevant preflight and inventory paths. Line-level blame and content-history inspection encountered unavailable promisor objects with HTTP 403, so feature introduction remains unverified. (scripts/preflight-external-pr-merge.mjs, 24f0340a1317)

Likely related people:

• vincentkoc: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)
• steipete: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

How this review workflow works

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

[clawsweeper]

🦞🔧
ClawSweeper is automatically building a fix for this issue.

The issue review finished and no active implementation pull request was found.

Automatic implementation progress:

• State: Queued
• Detail: Review complete; no active implementation PR was found. The Codex implementation worker is queued.
• Run: https://github.com/openclaw/clawsweeper/actions/runs/36368330404
• Updated: 2026-09-28T02:04:32.347Z
• Opt out: add clawsweeper:manual-only or clawsweeper:human-review.