refactor: share add activity schedule event modal#782
Open
anonymoususer72041 wants to merge 5 commits into
Open
refactor: share add activity schedule event modal#782anonymoususer72041 wants to merge 5 commits into
anonymoususer72041 wants to merge 5 commits into
Conversation
Contributor
Author
We might want to check if we should align some differences here before merging. |
anonymoususer72041
force-pushed
the
refactor/shared-activity-modal
branch
from
655bd65 to
59163a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the duplicated add activity / schedule event modal templates for candidates and contacts into a shared activity template.
The candidate, contact and job order entry points now pass the required modal configuration through template variables, while preserving the existing differences between those flows. This includes the parent module/action, hidden parent ID field, regarding job order options, modal title, validator path, cancel and close URLs, event duration visibility, field widths, reminder label text and focus behavior.
The candidate and contact regarding lists are normalized before rendering so the shared template can use the same structure for both flows. Candidate labels continue to include the related company name where applicable, while contact labels remain title-only.
A follow-up fix also removes undefined variable usage in the candidate job order finished path by avoiding access to unavailable pipeline data and using the current regarding job order ID for the cancel URL.