Skip to content

Flip quote types in pr filter, correct indentation level #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregorydlogan wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Flip quote types in pr filter, correct indentation level #1711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b3b256
Because of course GHA only supports single quotes here
gregorydlogan Jun 17, 2026
d6322e1
Correcting indentation level as well
gregorydlogan Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-main-branches.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
node-version: ${{ env.NODE_VERSION }}

- name: Ensure our node version matches the main repo's version for push events
if: github.event_name == 'push' && (startsWith("r/", github.ref_name) || "develop" == github.ref_name)
if: github.event_name == 'push' && (startsWith('r/', github.ref_name) || 'develop' == github.ref_name)
run: |
curl -s https://raw.githubusercontent.com/opencast/opencast/refs/heads/${{ github.ref_name }}/pom.xml -o pom.xml
export FOUND_VERSION="$(grep node.version pom.xml | grep -Eo 'v[0-9.]+' | cut -f 1 -d '.' | cut -c 2-)"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-test-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
&& exit 0 \
|| (echo "Node version does not match. Expected $NODE_VERSION, found $FOUND_VERSION"; exit 1)
- name: Ensure our node version matches the main repo's version for push events
if: github.event_name == 'push' && (startsWith("r/", github.ref_name) || "develop" == github.ref_name)
if: github.event_name == 'push' && (startsWith('r/', github.ref_name) || 'develop' == github.ref_name)
run: |
curl -s https://raw.githubusercontent.com/opencast/opencast/refs/heads/${{ github.ref_name }}/pom.xml -o pom.xml
export FOUND_VERSION="$(grep node.version pom.xml | grep -Eo 'v[0-9.]+' | cut -f 1 -d '.' | cut -c 2-)"
Expand Down
32 changes: 16 additions & 16 deletions .github/workflows/pr-test-playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,22 +26,22 @@ jobs:
with:
node-version: ${{ env.NODE_VERSION }}

- name: Ensure our node version matches the main repo's version for pull requests
if: github.event_name == 'pull_request'
run: |
curl -s https://raw.githubusercontent.com/opencast/opencast/refs/heads/${{ github.base_ref }}/pom.xml -o pom.xml
export FOUND_VERSION="$(grep node.version pom.xml | grep -Eo 'v[0-9.]+' | cut -f 1 -d '.' | cut -c 2-)"
[[ "$FOUND_VERSION" == "$NODE_VERSION" ]] \
&& exit 0 \
|| (echo "Node version does not match. Expected $NODE_VERSION, found $FOUND_VERSION"; exit 1)
- name: Ensure our node version matches the main repo's version for push events
if: github.event_name == 'push' && (startsWith("r/", github.ref_name) || "develop" == github.ref_name)
run: |
curl -s https://raw.githubusercontent.com/opencast/opencast/refs/heads/${{ github.ref_name }}/pom.xml -o pom.xml
export FOUND_VERSION="$(grep node.version pom.xml | grep -Eo 'v[0-9.]+' | cut -f 1 -d '.' | cut -c 2-)"
[[ "$FOUND_VERSION" == "$NODE_VERSION" ]] \
&& exit 0 \
|| (echo "Node version does not match. Expected $NODE_VERSION, found $FOUND_VERSION"; exit 1)
- name: Ensure our node version matches the main repo's version for pull requests
if: github.event_name == 'pull_request'
run: |
curl -s https://raw.githubusercontent.com/opencast/opencast/refs/heads/${{ github.base_ref }}/pom.xml -o pom.xml
export FOUND_VERSION="$(grep node.version pom.xml | grep -Eo 'v[0-9.]+' | cut -f 1 -d '.' | cut -c 2-)"
[[ "$FOUND_VERSION" == "$NODE_VERSION" ]] \
&& exit 0 \
|| (echo "Node version does not match. Expected $NODE_VERSION, found $FOUND_VERSION"; exit 1)
- name: Ensure our node version matches the main repo's version for push events
if: github.event_name == 'push' && (startsWith('r/', github.ref_name) || 'develop' == github.ref_name)
run: |
curl -s https://raw.githubusercontent.com/opencast/opencast/refs/heads/${{ github.ref_name }}/pom.xml -o pom.xml
export FOUND_VERSION="$(grep node.version pom.xml | grep -Eo 'v[0-9.]+' | cut -f 1 -d '.' | cut -c 2-)"
[[ "$FOUND_VERSION" == "$NODE_VERSION" ]] \
&& exit 0 \
|| (echo "Node version does not match. Expected $NODE_VERSION, found $FOUND_VERSION"; exit 1)

- name: Install dependencies
run: npm ci
Expand Down
Loading