Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log_mel_spectrogramaccepts NumPy waveforms, but a reversed or negatively strided view currently fails intorch.from_numpybefore computing the spectrogram. An equivalent contiguous array works:Copy the waveform only when it has a negative stride before converting it to a tensor. Contiguous and positive-stride arrays retain the existing conversion path. The added regressions compare positive and negative strides with the same waveform values for both 80 and 128 Mel filters, and check the input, output dtype, and CPU device.
Validation on Windows, Python 3.12.14, PyTorch 2.14.1+cpu, NumPy 2.5.3:
mainand pass all 8 with the fix; the 4 positive-stride controls pass on both.pytest tests/test_audio.py -q: 9 passed, including the bundled audio file decoded with FFmpeg..github/workflows/test.yml: 27 passed, 20 deselected, with the expected 2 CPU FP16 fallback warnings. This includes realtinyandtiny.entranscription with word timestamps using the official weights, verified against their SHA256 hashes.pre-commit run --all-files: passed.GPU execution, other model sizes, the complete Python/PyTorch CI matrix, and performance were not tested locally.