Repository navigation
Reject negative subtitle word limits instead of looping forever - #2869
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative
max_words_per_linemakes the subtitle writer loop forever:chunk_indexmoves backward while the loop condition remains true. This affects both SRT and VTT word-timestamp output, including values supplied through the options dictionary.Reject negative limits before iterating. Keep the existing behavior for
Noneand zero (no explicit limit), and for positive limits.Validation: reproduced the original hang in a subprocess stopped after three seconds. Four initial rejection tests fail on the original implementation. All 24 writer, normalizer, and tokenizer tests pass with the fix; Black, isort, flake8, and
git diff --checkpass. Added coverage for empty and populated results, both subtitle formats, both option paths, and unchanged positive/zero/default behavior. Model inference tests were not run for this writer-only change.