test: add missing prompt validation for sync and async resource methods#3078
Open
dhruvgupta2109 wants to merge 2 commits intoopenai:mainfrom
Open
test: add missing prompt validation for sync and async resource methods#3078dhruvgupta2109 wants to merge 2 commits intoopenai:mainfrom
dhruvgupta2109 wants to merge 2 commits intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new tests to ensure that required arguments are properly enforced in the OpenAI Python client, both for synchronous and asynchronous resource methods. The tests verify that appropriate exceptions are raised when mandatory parameters are missing.
Testing improvements:
OpenAIclient to check that aTypeErroris raised when required arguments (such asprompt,image, ormodel) are missing incompletions.create,images.edit, andaudio.transcriptions.createmethods.AsyncOpenAIclient to verify that missing required arguments inchat.completions.createandimages.generatecorrectly raise aTypeError.Dependency updates:
OpenAIandAsyncOpenAIclasses intests/test_required_args.pyto support the new tests.