Skip to content

sdk/metric: remove duplicated package path segment from manualReaderType - #9463

Open
dashpole wants to merge 1 commit into
open-telemetry:mainfrom
dashpole:fix-9450-component-type
Open

dashpole wants to merge 1 commit into
open-telemetry:mainfrom
dashpole:fix-9450-component-type

Conversation

@dashpole

@dashpole dashpole commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Part of #9450

Description

Removes the duplicated /metric package path segment from manualReaderType in sdk/metric/manual_reader.go:

  • "go.opentelemetry.io/otel/sdk/metric/metric.ManualReader" -> "go.opentelemetry.io/otel/sdk/metric.ManualReader"

Also tightens TestManualReaderInstrumentation in sdk/metric/manual_reader_test.go to assert the exact manualReaderType constant and otel.component.name prefix.

@dashpole
dashpole force-pushed the fix-9450-component-type branch from 1ab6872 to 64db2e4 Compare November 8, 2026 00:42
@dashpole
dashpole requested a balanced review from Copilot November 8, 2026 00:42
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Waiting on reviewers · refreshed 2026-11-09 21:17 UTC

Review the latest changes.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@codecov

codecov Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.8%. Comparing base (63c5f44) to head (d1ccb3c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #9463     +/-   ##
=======================================
- Coverage   89.8%   89.8%   -0.1%     
=======================================
  Files        357     357             
  Lines      23965   23977     +12     
=======================================
+ Hits       21535   21540      +5     
- Misses      2430    2437      +7     
Files with missing lines Coverage Δ
sdk/metric/manual_reader.go 83.7% <ø> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dashpole
dashpole marked this pull request as ready for review November 8, 2026 00:59
@dmathieu
dmathieu requested a balanced review from Copilot November 9, 2026 08:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new prefix assertion is never reached because the test producer emits no self-metric, causing the test to skip and leaving regressions in emitted component attributes undetected.

1 open issue

Review effort: Balanced

Comment thread sdk/metric/manual_reader_test.go Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants