Skip to content

Issue1488 Update custom parameters in sim#1495

Merged
annadellisola merged 2 commits into
masterfrom
issue1488_customParamSimInfoManager
Jun 30, 2026
Merged

Issue1488 Update custom parameters in sim#1495
annadellisola merged 2 commits into
masterfrom
issue1488_customParamSimInfoManager

Conversation

@annadellisola

Copy link
Copy Markdown
Contributor

This solves #1488.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses IDEAS issue #1488 by updating how local terrain/wind profile parameters are configured for the TwinHouses O5 experiment 1 example, avoiding illegal bindings to final parameters in PartialSimInfoManager.

Changes:

  • Replace direct bindings of A0 and a with locTer=Custom plus A0_custom/a_custom in the sim(...) modification.
  • Add a revisions entry referencing issue #1488 and introduce a Documentation(info=...) block in the model annotation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread IDEAS/Examples/TwinHouses/BuildingO5_Exp1.mo Outdated
Comment thread IDEAS/Examples/TwinHouses/BuildingO5_Exp1.mo Outdated
@LoneMeertens

Copy link
Copy Markdown
Contributor

@annadellisola Thank you for handling this issue! :)

The fix looks good to me. Using A0_custom and a_custom instead of overriding the final parameters A0 and a resolves the reported error. I think this PR is ready to be merged.

@annadellisola annadellisola merged commit d5b7216 into master Jun 30, 2026
2 checks passed
@annadellisola annadellisola deleted the issue1488_customParamSimInfoManager branch June 30, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants