docs: Update isolated API instance creation to use OpenFeatureFactory#756
Open
askpt wants to merge 1 commit into
Open
docs: Update isolated API instance creation to use OpenFeatureFactory#756askpt wants to merge 1 commit into
askpt wants to merge 1 commit into
Conversation
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 69 69
Lines 2981 2981
Branches 355 355
=======================================
Hits 2788 2788
Misses 135 135
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates the console sample to use OpenFeatureFactory.CreateIsolated() instead of Api.CreateIsolated() and adds the OpenFeature.Isolated namespace. It also introduces pragma suppressions for the experimental API. Feedback suggests simplifying the pragma suppression comments to improve readability in the sample code.
kylejuliandev
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: André Silva 2493377+askpt@users.noreply.github.com
This PR
This pull request updates the
samples/Console/app.cssample to use the newOpenFeatureFactory.CreateIsolated()method for creating an isolated OpenFeature instance, instead of the olderApi.CreateIsolated(). It also adds the necessaryOpenFeature.Isolatednamespace import.Migration to new isolated API:
Api.CreateIsolated()withOpenFeatureFactory.CreateIsolated()for creating an isolated OpenFeature instance, and added pragma directives to suppress related warnings.Namespace updates:
using OpenFeature.Isolated;to support the new isolated API.