Skip to content

docs: Update isolated API instance creation to use OpenFeatureFactory#756

Open
askpt wants to merge 1 commit into
mainfrom
askpt/fix-sample
Open

docs: Update isolated API instance creation to use OpenFeatureFactory#756
askpt wants to merge 1 commit into
mainfrom
askpt/fix-sample

Conversation

@askpt
Copy link
Copy Markdown
Member

@askpt askpt commented May 12, 2026

Signed-off-by: André Silva 2493377+askpt@users.noreply.github.com

This PR

This pull request updates the samples/Console/app.cs sample to use the new OpenFeatureFactory.CreateIsolated() method for creating an isolated OpenFeature instance, instead of the older Api.CreateIsolated(). It also adds the necessary OpenFeature.Isolated namespace import.

Migration to new isolated API:

  • Replaced Api.CreateIsolated() with OpenFeatureFactory.CreateIsolated() for creating an isolated OpenFeature instance, and added pragma directives to suppress related warnings.

Namespace updates:

  • Added using OpenFeature.Isolated; to support the new isolated API.

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt askpt marked this pull request as ready for review May 12, 2026 21:01
@askpt askpt requested a review from a team as a code owner May 12, 2026 21:01
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (b3fa7f4) to head (06116d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files          69       69           
  Lines        2981     2981           
  Branches      355      355           
=======================================
  Hits         2788     2788           
  Misses        135      135           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the console sample to use OpenFeatureFactory.CreateIsolated() instead of Api.CreateIsolated() and adds the OpenFeature.Isolated namespace. It also introduces pragma suppressions for the experimental API. Feedback suggests simplifying the pragma suppression comments to improve readability in the sample code.

Comment thread samples/Console/app.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants