fix(review): re-review stale approvals on current head - #528
Closed
rianjs wants to merge 1 commit into
Closed
Conversation
![rianjs-bot[bot]](https://avatars.githubusercontent.com/u/7378790?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: d06896d3fa5a
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]
Summary
| Reviewer | Findings |
|---|---|
| go:implementation-tests | 0 |
| policies:conventions | 0 |
| structure:repo-health | 0 |
Reviewer Coverage
| Reviewer | Status | Inspected | Skipped | Constraints |
|---|---|---|---|---|
| go:implementation-tests | complete_broad | internal/app/runtime_test.go, internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go, internal/gateio/gateio.go, internal/gateio/gateio_test.go | unavailable | Focused review limited to the assigned changed files. Targeted Go tests could not run because the configured Go build-cache path is outside the writable sandbox. |
| policies:conventions | complete_broad | internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go | unavailable | Review limited to the two assigned changed files; shared CLI standards convenience checkout was not present. |
| structure:repo-health | complete_broad | internal/app/runtime_test.go, internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go, internal/gateio/gateio.go, internal/gateio/gateio_test.go | unavailable | Focused structural review limited to the assigned changed files and their immediate provider contracts. |
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 57s | unavailable | gpt-5.6-terra | cr 0.10.267
| Field | Value |
|---|---|
| Model | gpt-5.6-terra |
| Reviewers | go:implementation-tests, policies:conventions, structure:repo-health |
| Engine | codex_cli · gpt-5.6-terra |
| Reviewed by | cr · rianjs-bot[bot] |
| Duration | 1m 57s wall · 4m 05s compute |
| Cost | unavailable |
| Tokens | 1.1M in / 11.2k out |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost | Duration |
|---|---|---|---|---|---|---|---|
| orchestrator-selection | gpt-5.6-terra | 16.8k | 328 | 11.0k | unavailable | unavailable | 11s |
| go:implementation-tests | gpt-5.6-terra | 344.4k | 4.0k | 292.4k | unavailable | unavailable | 1m 24s |
| policies:conventions | gpt-5.6-terra | 223.8k | 2.3k | 183.3k | unavailable | unavailable | 51s |
| structure:repo-health | gpt-5.6-terra | 460.7k | 4.2k | 404.7k | unavailable | unavailable | 1m 32s |
| orchestrator-rollup | gpt-5.6-terra | 35.4k | 367 | 27.1k | unavailable | unavailable | 5s |
rianjs
changed the title
rianjs
force-pushed
the
rianjs/MON-6650/current-head-review
branch
from
August 1, 2026 09:36
d06896d to
7e0f0cd
Compare
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 7e0f0cdcc12b
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]
Summary
| Reviewer | Findings |
|---|---|
| go:implementation-tests | 0 |
| policies:conventions | 1 |
| structure:repo-health | 0 |
policies:conventions (1 finding)
Minor - internal/cmd/reviewcmd/reviewcmd.go:34
Document this durable gate semantic in
docs/review-lifecycle.md, which is declared the canonical end-to-end lifecycle forcr review. The help text is useful for users, but future implementers following the lifecycle still cannot see that only an approval bound to the current PR head short-circuits a normal run (and that revision-unbound approvals continue into review).
Reviewer Coverage
| Reviewer | Status | Inspected | Skipped | Constraints |
|---|---|---|---|---|
| go:implementation-tests | complete_broad | internal/app/runtime_test.go, internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go, internal/gateio/gateio.go, internal/gateio/gateio_test.go | unavailable | Default cgo-enabled package tests could not compile because the sandbox checkout path contains spaces; the focused suites passed with CGO_ENABLED=0. |
| policies:conventions | complete_broad | internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go | unavailable | Reviewed the assigned command implementation and tests; shared-standard convenience copies were not present. |
| structure:repo-health | complete_broad | internal/app/runtime_test.go, internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go, internal/gateio/gateio.go, internal/gateio/gateio_test.go | unavailable | Focused on assigned changed files; targeted tests passed with CGO_ENABLED=0 because the environment's spaced workspace path breaks the default C compiler invocation. |
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 41s | unavailable | gpt-5.6-terra | cr dev
| Field | Value |
|---|---|
| Model | gpt-5.6-terra |
| Reviewers | go:implementation-tests, policies:conventions, structure:repo-health |
| Engine | codex_cli · gpt-5.6-terra |
| Reviewed by | cr · rianjs-bot[bot] |
| Duration | 1m 41s wall · 3m 12s compute |
| Cost | unavailable |
| Tokens | 899.7k in / 7.7k out |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost | Duration |
|---|---|---|---|---|---|---|---|
| orchestrator-selection | gpt-5.6-terra | 57.0k | 645 | 38.1k | unavailable | unavailable | 8s |
| go:implementation-tests | gpt-5.6-terra | 358.6k | 2.7k | 303.1k | unavailable | unavailable | 1m 18s |
| policies:conventions | gpt-5.6-terra | 102.2k | 1.4k | 76.8k | unavailable | unavailable | 34s |
| structure:repo-health | gpt-5.6-terra | 301.3k | 2.2k | 246.0k | unavailable | unavailable | 1m 05s |
| orchestrator-rollup | gpt-5.6-terra | 80.5k | 726 | 59.4k | unavailable | unavailable | 5s |
rianjs
force-pushed
the
rianjs/MON-6650/current-head-review
branch
from
August 1, 2026 09:44
7e0f0cd to
0c85374
Compare
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 0c85374d6895
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]
Summary
| Reviewer | Findings |
|---|---|
| go:implementation-tests | 0 |
| policies:conventions | 0 |
| structure:repo-health | 0 |
Reviewer Coverage
| Reviewer | Status | Inspected | Skipped | Constraints |
|---|---|---|---|---|
| go:implementation-tests | complete_constrained | internal/app/runtime_test.go, internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go, internal/gateio/gateio.go, internal/gateio/gateio_test.go | unavailable | Read-only sandbox prevented Go from initializing its build cache, so focused tests could not be rerun in this checkout. |
| policies:conventions | complete_constrained | docs/review-lifecycle.md, internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go | unavailable | Reviewed assigned files; shared-standard convenience copies were not present. |
| structure:repo-health | complete_constrained | internal/app/runtime_test.go, internal/cmd/reviewcmd/reviewcmd.go, internal/cmd/reviewcmd/reviewcmd_test.go, internal/gateio/gateio.go, internal/gateio/gateio_test.go | unavailable | Read-only sandbox prevented Go test execution because the build cache could not be initialized. |
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 15s | unavailable | gpt-5.6-terra | cr dev
| Field | Value |
|---|---|
| Model | gpt-5.6-terra |
| Reviewers | go:implementation-tests, policies:conventions, structure:repo-health |
| Engine | unavailable · gpt-5.6-terra |
| Reviewed by | cr · rianjs-bot[bot] |
| Duration | 1m 15s |
| Cost | unavailable |
| Tokens | unavailable |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost | Duration |
|---|---|---|---|---|---|---|---|
| orchestrator-selection | unavailable | unavailable | unavailable | unavailable | unavailable | unavailable | unavailable |
| go:implementation-tests | gpt-5.6-terra | 500.3k | 3.2k | 429.6k | unavailable | unavailable | 17s |
| policies:conventions | gpt-5.6-terra | 189.2k | 1.9k | 148.0k | unavailable | unavailable | 13s |
| structure:repo-health | gpt-5.6-terra | 527.8k | 4.2k | 448.0k | unavailable | unavailable | 43s |
| orchestrator-rollup | gpt-5.6-terra | 105.5k | 765 | 82.7k | unavailable | unavailable | 5s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The gate selected the latest decisive review by state but ignored its
CommitSHA. After a push, an older approval therefore short-circuited review of the new head.Impact
Current-head approvals retain the cheap early exit. Older or revision-unbound approvals fail closed into a normal review of the current head.
Validation
go test ./internal/gateio ./internal/app ./internal/cmd/reviewcmd— 233 passedgo test ./...— 2,869 passed, 2 skipped, and one unrelated date-sensitivedatacmdtest failed identically on untouchedorigin/main