Get build to work on macOS#35
Merged
Merged
Conversation
Today, the README gives some information for how to link the python interpreter and expects the user to find their way. This commit only enables PyO3 extension-module for maturin builds, but disable it for plain cargo builds. This way, Rust test binaries link libpython correctly. Along the way, we remove some unused configuration flags in build.rs, and add wheels/ to .gitignore.
Collaborator
|
Hi @hellais! I've tested it on my machine and made an extra commit for the following:
println!("cargo:rustc-check-cfg=cfg(Py_3_10)");
println!("cargo:rustc-check-cfg=cfg(Py_3_11)");
println!("cargo:rustc-check-cfg=cfg(Py_3_12)");
println!("cargo:rustc-check-cfg=cfg(Py_3_13)");
println!("cargo:rustc-check-cfg=cfg(Py_3_14)");
println!("cargo:rustc-check-cfg=cfg(Py_3_15)");
I'm OK to remove (4), and otherwise the patch looks good to me. |
Collaborator
|
@hellais friendly bump here! |
mmaker
reviewed
May 19, 2026
Collaborator
mmaker
left a comment
mmaker
left a comment
There was a problem hiding this comment.
On my machines this still doesn't compile.
Comment on lines
+13
to
+18
| println!("cargo:rustc-check-cfg=cfg(Py_3_10)"); | ||
| println!("cargo:rustc-check-cfg=cfg(Py_3_11)"); | ||
| println!("cargo:rustc-check-cfg=cfg(Py_3_12)"); | ||
| println!("cargo:rustc-check-cfg=cfg(Py_3_13)"); | ||
| println!("cargo:rustc-check-cfg=cfg(Py_3_14)"); | ||
| println!("cargo:rustc-check-cfg=cfg(Py_3_15)"); |
Collaborator
There was a problem hiding this comment.
We don't seem to be using any of these flags, are these lines necessary?
Collaborator
|
@hellais bump here! |
Collaborator
|
I tested this locally on linux and seems to be working FYI |
LDiazN
approved these changes
May 26, 2026
Member
Author
|
Thanks for updating the readme docs and making the extension module optional. I don't think we need the For me this is good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
pyo3_build_configto build correct build and linker flags on macOS.