feat: implement automated desktop screenshot capture and refactor common test helpers#1336
Open
aanorbel wants to merge 4 commits into
Open
feat: implement automated desktop screenshot capture and refactor common test helpers#1336aanorbel wants to merge 4 commits into
aanorbel wants to merge 4 commits into
Conversation
aanorbel
force-pushed
the
feat/desktop-screenshot
branch
from
1445788 to
2e52f9f
Compare
sdsantos
requested changes
May 11, 2026
Contributor
sdsantos
left a comment
sdsantos
left a comment
There was a problem hiding this comment.
We should be able to simplify that dependencies part of the PR.
And next we need some script to convert the screenshots to their final version, with the desktop and UI around them no?
| import java.nio.file.Path | ||
| import java.util.Locale | ||
|
|
||
| internal fun buildScreenshotDependencies(workingDir: Path): Dependencies { |
Contributor
There was a problem hiding this comment.
Instead of repeating so much code for building dependencies, we should have a buildDependencies function that is both used by the main and test flavors, with arguments that could change what we need.
aanorbel
force-pushed
the
feat/desktop-screenshot
branch
from
ecf28cb to
436b7fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.