fix(room-booking): Room booking animation fix#367
Open
ARCshekin wants to merge 2 commits into
Open
Conversation
…utlook When room booking is declined by outlook, error was returned as an object, but string expected. Since that, Error 403: [object Object] appeared on frondend. I added additional conditions to always satisfy object type and extract message from "details" object
…>" page Before closing this pop-out window fields were erased (set to "undefined"), it was visible to user and broke quality of animation. I just removed this action (as it is done in "timeline" pop-out window). It is safe since memory will be updated with opening next booking.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| } | ||
| if ( | ||
| typeof detail === "object" && | ||
| detail !== null && |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Before closing this pop-out window fields were erased (set to "undefined"), it was visible to user and broke quality of animation. I just removed this action (as it is done in "timeline" pop-out window). It is safe since memory will be updated with opening next booking.
chrome: https://github.com/user-attachments/assets/b95f9843-527f-4c94-a220-24a6d6e2afad
safari: https://github.com/user-attachments/assets/3a7c8993-fc3f-4db6-8235-132107bf85c9
firefox: https://github.com/user-attachments/assets/d9530c80-f338-4857-8d98-f6d8dbfa3747