Repository navigation
Conversation
Temporary: depends on janelia-jhdf5 22.03.01-SNAPSHOT, adds the bytedeco snapshot repository and a CI step that builds janelia-jhdf5 first. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
components/formats-bsd/pom.xml: replacecisd:jhdf5:19.04.1withorg.scijava:janelia-jhdf5:22.03.01-SNAPSHOT. Thetest-no-hdfsurefire execution now excludesorg.scijava:janelia-jhdf5from the classpath.JHDFServiceImpl: the "JHDF is required" message no longer points to the obsoletecisd-jhdf5-batteries_included_lin_win_mac.jar.ch.systemsx.cisd.hdf5.*/ch.systemsx.cisd.base.*packages.pom.xml, and two steps in.github/workflows/maven.ymlthat build and install the janelia-jhdf5 snapshot before the Bio-Formats build.Why
cisd:jhdf5 19.04.1 is unmaintained, bundles old HDF5 1.10 natives and only supports a few platforms. janelia-jhdf5 is a drop-in replacement with the same API that runs on HDF5 2.x through bytedeco and supports more platforms (including macOS arm64, Linux arm64, Windows). Many downstream projects get JHDF5 transitively through Bio-Formats.
Draft: waiting on a janelia-jhdf5 release
janelia-jhdf5 is not released yet (22.03.01-SNAPSHOT, which also needs javacpp/hdf5 1.5.15-SNAPSHOT / 2.2.0 from the bytedeco snapshot repo). When released: set the real version in formats-bsd/pom.xml, remove the snapshot repository from the root pom.xml, and remove the two janelia-jhdf5 steps from maven.yml.
Testing
Locally on JDK 21, with janelia-jhdf5 installed in ~/.m2:
mvn -pl components/formats-bsd -am installpassed: formats-bsd 1525 tests (includes JHDFServiceTest) plus thetest-no-hdfrun (MissingJHDFServiceTest) with 0 failures; formats-api 224 tests passed.dependency:treeshows nocisd:*artifacts. Only formats-bsd referenced jhdf5, so other modules were not rebuilt. Not run: the CI matrix (Java 11/17/21/25 on 3 OSes) and the Java 8 baseline.Licensing
janelia-jhdf5: BSD-3-Clause for new code, Apache-2.0 for inherited JHDF5/cisd:base code. Dependencies: bytedeco hdf5/javacpp (HDF5 license, Apache-2.0 or GPLv2+Classpath), jnr-posix (EPL-2.0 / GPL-2 / LGPL-2.1 multi-license).
🤖 Generated with Claude Code