Repository navigation
OME-TIFF: remove extra Channels all at once - #4489
Open
melissalinkert wants to merge 2 commits into
Open
melissalinkert wants to merge 2 commits into
melissalinkert wants to merge 2 commits into
Conversation
This means the MetadataStore root only needs to be reset once, which for OMEPyramidStore (with resolution annotations present) means the memory usage is substantially reduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means the
MetadataStoreroot only needs to be reset once, which forOMEPyramidStore(with resolution annotations present) means the memory usage is substantially reduced.The issue can be demonstrated by converting
test&plateRows=16&plateCols=24&fields=6&sizeX=512&sizeY=512&sizeC=3.faketo OME-TIFF through bioformats2raw/raw2ometiff and then runningshowinf -nopix -omexmlon the OME-TIFF. AnOutOfMemoryErrorshould occur with default memory settings forshowinf, i.e.BF_MAX_MEMwas unset.With this change and the same OME-TIFF,
showinf -nopix -omexmlwith default memory completes and prints OME-XML without error. SettingBF_MAX_MEMas low as230m(less than half of the default) should also work.No impact on existing tests is expected.