Conversation
Agent-Logs-Url: https://github.com/omar2535/GraphQLer/sessions/803a32d8-f1f8-4a7a-bc79-86f0cb989997 Co-authored-by: omar2535 <[email protected]>
Agent-Logs-Url: https://github.com/omar2535/GraphQLer/sessions/803a32d8-f1f8-4a7a-bc79-86f0cb989997 Co-authored-by: omar2535 <[email protected]>
Agent-Logs-Url: https://github.com/omar2535/GraphQLer/sessions/803a32d8-f1f8-4a7a-bc79-86f0cb989997 Co-authored-by: omar2535 <[email protected]>
Agent-Logs-Url: https://github.com/omar2535/GraphQLer/sessions/803a32d8-f1f8-4a7a-bc79-86f0cb989997 Co-authored-by: omar2535 <[email protected]>
…bjects bucket Agent-Logs-Url: https://github.com/omar2535/GraphQLer/sessions/8847e94f-17d0-4e5c-b2d9-cb0d4172e3d6 Co-authored-by: omar2535 <[email protected]>
Copilot created this pull request from a session on behalf of
omar2535
April 17, 2026 22:34
View session
There was a problem hiding this comment.
Pull request overview
Fixes a fuzzing/scheduling failure where list/connection queries (e.g., CountryConnection { items: [Country] }) seeded only the wrapper object into ObjectsBucket, leaving inner domain objects (e.g., Country) unavailable for later ID-based queries and dependency scheduling.
Changes:
- Always store successful query responses in
ObjectsBucket(previously list responses were dropped). - Unpack common connection wrapper patterns (
items/nodes/edges.node) to store inner objects under their real object type. - Annotate compiled queries with a
producesinner-type and add dependency-graph edges so list/connection queries are scheduled before queries that depend on the inner object type.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
graphqler/fuzzer/engine/fengine.py |
Always calls objects_bucket.put_in_bucket(result.data) on query success to avoid dropping list responses. |
graphqler/utils/objects_bucket.py |
Adds connection-wrapper unpacking logic and schema-guided inner-type resolution to seed inner OBJECTs into the bucket. |
graphqler/compiler/resolvers/query_object_resolver.py |
Adds produces annotation for list/connection queries by inspecting wrapper output fields. |
graphqler/graph/graph_generator.py |
Adds “Case 4” edges (Query -> produced inner Object) to improve scheduling/topological ordering. |
tests/unit/utils/test_objects_bucket_connection.py |
New unit tests validating wrapper unpacking (items, nodes, edges.node) and parse_as_object behavior. |
tests/unit/compiler/resolvers/test_query_object_resolver.py |
New unit tests for _resolve_produces across items/nodes/Relay edges cases. |
sample-graphql-apis/user-wallet-api/package-lock.json |
Minor lockfile metadata change (removes a peer flag entry). |
Files not reviewed (1)
- sample-graphql-apis/user-wallet-api/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/omar2535/GraphQLer/sessions/d5e91cec-bcac-4b21-acf1-2be6f81f0705 Co-authored-by: omar2535 <[email protected]>
omar2535
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytestimport fromtests/unit/utils/test_objects_bucket_connection.pypytestimport fromtests/unit/compiler/resolvers/test_query_object_resolver.pygraphqler/compiler/resolvers/query_object_resolver.py— "mutations" → "queries"