Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With more than one monitor, only the focused one can be selected. Hyprland keeps pointer focus on the overlay's exclusive-keyboard layer surface even when the cursor is on another output, so the overlay just gets motion past its own edge. That is also where the stray size badges in #166 come from.
After the overlay's first paint, a worker captures the other monitors and shows each one frozen and dimmed on its own layer surface. When the overlay sees motion past its edge, it moves to the monitor under the cursor and uses that monitor's frame and windows. Before it leaves a monitor, that monitor gets its own frozen layer first so the live desktop doesn't flash through. Clicks past the edge are ignored. The extra layers are removed when selection ends.
Fixes the selection part of #166. The editor placement from #164 is in #165.
Testing:
Going back to select from the editor stays on the current monitor, same as before.