fix(editor): preserve capture size in exported PNGs - #163
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a saved screenshot from a 2× monitor through Omaroll's Annotate action or a file browser treated its native pixels as logical dimensions, making it appear twice its original size. Store the rendered capture's logical dimensions in the exported PNG and restore them when reopening the file or clipboard image. Native pixels remain intact, including crops, backdrops, expanded canvases, and scrolling captures.
Editable operation logs retain precedence over the PNG dimensions, and untagged images keep their existing pixel-sized presentation. The fast PNG encoder writes the small size field directly; other metadata continues through Qt's existing fallback.
Validation:
make checkpassed, including scale round trips at 1×, 1.25×, 1.5×, and 2×, Save As and preview exports, invalid metadata, exact pixel preservation, and unchanged compressed image payloads.