Skip to content

Show Bluetooth Alias ahead of the hardware Name #9653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chessing234 wants to merge 2 commits into from
Closed

Show Bluetooth Alias ahead of the hardware Name #9653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e5ffc3
fix: show Bluetooth Alias ahead of the hardware Name
Chessing234 Sep 1, 2026
cb830c9
Flip the label test to the alias-first order
omarchybot Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/plugins/panels/bluetooth/Model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
function deviceLabel(device) {
if (!device) return ""
return String(device.deviceName || device.name || "").trim()
return String(device.name || device.deviceName || "").trim()
}

function toArray(values) {
Expand Down
10 changes: 9 additions & 1 deletion test/shell.d/bluetooth-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,16 @@ assertDeepEqual(
{ address: '1', name: 'Deadbeef', deviceName: '', connected: false, state: -1, batteryAvailable: false, battery: 0, pairing: false },
'bluetooth projects device rows with primitives only'
)
// BlueZ Alias is the user-facing rename and arrives as Quickshell's writable
// `name`; the read-only `deviceName` is the hardware-advertised Name, which is
// only what to show when nothing renamed the device.
assertEqual(
bluetooth.deviceLabel(bluetooth.deviceRow({ name: 'Generic', deviceName: 'MX Master 3S', address: '2', connected: true })),
bluetooth.deviceLabel(bluetooth.deviceRow({ name: 'My Custom Name', deviceName: 'MX Master 3S', address: '2', connected: true })),
'My Custom Name',
'bluetooth shows the alias ahead of the hardware name'
)
assertEqual(
bluetooth.deviceLabel(bluetooth.deviceRow({ deviceName: 'MX Master 3S', address: '2', connected: true })),
'MX Master 3S',
'bluetooth keeps deviceName in row projections so labels survive QObject-free rows'
)
Expand Down