Repository navigation
Prefer apple-panel-bl over the Asahi DSI backlight decoy - #8131
Closed
Chessing234 wants to merge 1 commit into
Closed
Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
On Apple Silicon, /sys/class/backlight lists both apple-panel-bl (the real panel) and a numeric DSI node that sorts first alphabetically and accepts writes with no visible effect. Put apple-panel-bl after gmux so T2 dual-GPU Macs still prefer gmux, and keep excluding the Touch Bar. Fixes omacom#8125
Contributor
There was a problem hiding this comment.
Pull request overview
Prioritizes the functional Asahi apple-panel-bl device while preserving existing backlight precedence.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Adds
apple-panel-blafter gmux and before GPU backlights. - Tests Asahi DSI, gmux, and Touch Bar selection behavior.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/omarchy-hw-display |
Prioritizes the real Asahi panel backlight. |
test/shell.d/hw-display-test.sh |
Covers Apple backlight precedence and exclusions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@dhh @ryanrhughes ready for review |
1 task
Contributor
Author
|
folded into #12267 for easier review. |
Chessing234
added a commit
to Chessing234/omarchy
that referenced
this pull request
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Apple Silicon,
/sys/class/backlightlists bothapple-panel-bl(the real panel) and a numeric DSI node that sorts first alphabetically and accepts writes with no visible effect.omarchy-hw-displayhad noapple-panel-blin its candidate list, so it fell through to that decoy and brightness slider/keys no-op'd.Put
apple-panel-blafter gmux (T2 dual-GPU Macs still want gmux first) and before GPU PWM devices. Keep excludingappletb_backlight(Touch Bar). Existing gmux/amdgpu/intel/acpi order is unchanged.hw-display-test.shis at 12 assertions: Asahi DSI decoy loses toapple-panel-bl, gmux still wins on T2, Touch Bar stays unused.Fixes #8125