Skip to content

Give screen recording stop more than five seconds to mux #12559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bartok9 wants to merge 3 commits into
base: quattro
Choose a base branch
from
Open

Give screen recording stop more than five seconds to mux #12559

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db9bc49
Give screen recording stop more than five seconds to mux
Bartok9 Sep 19, 2026
2477ae0
Harden screenrecord stop timeout parsing
Bartok9 Sep 25, 2026
7ce02b9
Reject non-ASCII digits in screenrecord stop timeout
Bartok9 Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions bin/omarchy-capture-screenrecording
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
# the picker target it was launched with) to
# $XDG_RUNTIME_DIR/omarchy-screenrecord.log so users can attach a log when
# reporting capture failures.
#
# Env: OMARCHY_SCREENRECORD_STOP_TIMEOUT=<seconds> overrides the stop grace period
# after SIGINT (default 30, clamped 1..600). Non-ASCII-digit or more-than-five-
# digit strings fall back to 30; 1..5 ASCII digits are base-10 and clamped.

[[ -f ~/.config/user-dirs.dirs ]] && source ~/.config/user-dirs.dirs
OUTPUT_DIR="${OMARCHY_SCREENRECORD_DIR:-${XDG_VIDEOS_DIR:-$HOME/Videos}}"
Expand Down Expand Up @@ -219,9 +223,21 @@ start_screenrecording() {
stop_screenrecording() {
pkill -SIGINT -f "^gpu-screen-recorder" # SIGINT required to save video properly

# Wait a maximum of 5 seconds to finish before hard killing
# Wait for the muxer to write the trailer. Five seconds is too short on a
# loaded or thermally throttled machine and SIGKILL then truncates the file
# (issue #12469). Honour OMARCHY_SCREENRECORD_STOP_TIMEOUT seconds, default 30.
# Digit-only values still need base-10 forcing and a small upper bound so
# leading zeros are not octal and huge inputs cannot overflow the *10 bound.
local timeout_s=${OMARCHY_SCREENRECORD_STOP_TIMEOUT:-30}
# Explicit ASCII digits only: locale [0-9] can match non-ASCII digits and
# then 10#$timeout_s aborts the stop path under glibc UTF-8 locales.
[[ $timeout_s =~ ^[0123456789]{1,5}$ ]] || timeout_s=30
timeout_s=$((10#$timeout_s))
((timeout_s < 1)) && timeout_s=1
((timeout_s > 600)) && timeout_s=600
local count=0
while pgrep -f "^gpu-screen-recorder" >/dev/null && ((count < 50)); do
local max=$((timeout_s * 10))
while pgrep -f "^gpu-screen-recorder" >/dev/null && ((count < max)); do
sleep 0.1
count=$((count + 1))
done
Expand Down