Bar status: Steam idle-inhibit, Wi-Fi/SSID, Bluetooth alias/pairable - #12114
Chessing234 wants to merge 8 commits into
Conversation
Signed-off-by: Taksh <takshkothari09@gmail.com>
^steam_app_ only matches the literal class steam_app_, so games never got the idle inhibitor. Add a test that pins the FullMatch pattern.
Signed-off-by: Taksh <takshkothari09@gmail.com>
Substituting any non-wireless route hid ethernet (and bonds, WWAN) whenever Wi-Fi was associated. Gate on TUN/TAP/PPP and apply the same device to --verbose so the panel matches the bar.
Signed-off-by: Taksh <takshkothari09@gmail.com>
The projection assertion pinned deviceName ahead of name, which is the precedence this branch reverses, so it fails as written. Its purpose was that deviceRow carries deviceName through to QObject-free rows, and a device with no alias still proves that. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
33f6fb2 to
33c7120
Compare
Automated AI review
Verified: four of the five changes do what they claim. The tunnel handling in
VPN over Ethernet with Wi-Fi still associated is now reported as Wi-Fi
Stubbed
Impact: in that last case the network panel is titled with the SSID and computes Receiving/Sending from the idle Wi-Fi counters, so it shows near-zero throughput while traffic flows over Ethernet. The speed test is also titled with the SSID. In Suggested change: when the route device is a tunnel, use the device of the lowest-metric non-tunnel default route in the main table ( Tunnel detection misses TAP and catches modems
Impact: a TAP VPN over Wi-Fi is still reported as Suggested change: test Pairable off also makes pairings started from this machine non-bondingBlueZ documents Pairable as affecting only incoming pairing, but the kernel also applies it to pairings this machine starts (Linux v7.2, source-verified, no hardware run): BlueZ's Impact: pairing from the panel is fine while the panel is open. Pairing started with Suggested change: have Hypothesis: BlueZ can turn Pairable back on while the panel is closedWith the stock To settle: after login, without opening the panel, run Suggested change (if confirmed): in the existing Overlapping open PRs
Optional: with the alias-first label, a device whose alias is MAC-, UUID- or whitespace-shaped while its Optional test improvement: these diagnostic mutants of head leave the tests green:
Review informationTest scope: Source review of head AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check. Opt out: To stop receiving these reviews, reply to this comment saying so. |
|
Reviewed at head
I agree with your note above about holding these until the overlapping pull requests are decided. Bundled, this pull request cannot land without conflicting with three others, so I have not marked it verified or ready. The maintainer decides which approach lands for each part. If the SSID decode were split back into its own pull request (as #8235 was), it could be reviewed and verified on its own. |
Summary
Test plan