Recognize Ecosia as a Chromium-family browser in omarchy-launch-webapp - #11164
Open
mattlibera wants to merge 1 commit into
Open
mattlibera wants to merge 1 commit into
mattlibera wants to merge 1 commit into
Conversation
Ecosia's default-browser desktop id (org.ecosia.Browser.desktop) fell through to the chromium.desktop fallback, so web apps (including protocol-handler launches like Zoom's) silently opened in a separate, unauthenticated Chromium profile instead of the user's actual signed-in Ecosia session. Ecosia is Chromium-based (AUR: ecosia-browser-bin) and supports --app mode like the other recognized browsers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
omarchy-launch-webappwhitelists a fixed set of Chromium-family default-browser desktop ids and falls back to a hardcodedchromium.desktopfor anything not on the list:Ecosia's default-browser id (
org.ecosia.Browser.desktop) isn't on that list, so it silently falls into thechromium.desktopbranch. Every web app launch — including protocol-handler launches like Zoom'somarchy-webapp-handler-zoom— then opens in a separate, unauthenticated Chromium profile instead of the user's real, signed-in Ecosia profile. From the user's perspective, the web app "forgets" who they are and any state (e.g. a partially-typed meeting number) on every single launch, because it isn't actually their browser.Ecosia is Chromium-based (packaged in the AUR as
ecosia-browser-bin, currently tracking Chromium 152.x) and supports--appmode exactly like the browsers already on this list, so it belongs in the same bucket as e.g. Helium (#3225).Fix
Add
org.ecosia.Browser* | ecosia*to the recognized case, matching both the desktop idxdg-settingsreports and the raw exec name, the same pattern already used for the other entries.Testing
test/shell.d/launch-webapp-browser-test.sh, covering:--app=<url>instead of falling back tochromium.desktop.chromium.desktop(existing behavior preserved)../test/clipasses fully../test/shell: 52-53 files fail identically with and without this change on this sandbox (no compositor/hardware available), confirming they're pre-existing environment-dependent failures unrelated to this diff.