Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing 'xhs' finds 小红书, 'dy' finds 抖音, 'wx' finds 微信.
Both search paths (MenuModel nameSearchText and AppSearch entrySearchText) gain a dependency-free pinyin-initials index: a generated 21k-entry first-letter table for CJK U+4E00-U+9FFF appended to the existing search haystacks, so current substring/acronym scoring applies unchanged.
Trade-offs: Hanzi initials only (Latin is already searchable; passing it through glued cross-word pairs like 'recording capture' -> 'gc', caught by the existing acronym test). Polyphonic characters match their most common reading only.
Tests: new assertions in app-search-test.sh and menu-test.sh cover xhs/dy/wx plus a negative; both suites and menu-guards pass. Full ./test/shell shows only failures that also fail on a clean tree (missing omarchy-pkgs checkout, compositor animation test).