Repository navigation
Build settings for #13362's HOOKS baseline without a detector copy - #773
Merged
Merged
Conversation
omacom/omarchy#13362 (d0b94d98c) dropped the omarchy-hw-platform copy omarchy-settings shipped beside its platform guard. Its 00-omarchy-hooks.conf now asks the runtime's own detector on PATH, and keeps the busybox line where there is none. The aarch64 settings recipes still refused any source whose baseline names omarchy-hw-platform without that copy, so every aarch64 build of quattro would fail once #13362 merges. Both recipes drop that check. The copy is still installed when a source ships the guard, as before. The test fixture follows #13362's current baseline, and the split-layout test checks the package builds from it and ships no copy.
The build planner only builds a recipe whose version changed, so the aarch64 builds had nothing to check. The packages' contents are unchanged.
Contributor
Publish succeeded → livePackages: omarchy-settings (x86_64, PR artifact); omarchy-settings (aarch64, PR artifact); omarchy-settings-dev (x86_64, PR artifact); omarchy-settings-dev (aarch64, PR artifact)
Some planned slots did not run because an earlier slot failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converge omarchy-mac and omarchy-mx-mac into upstream Omarchy omarchy#13362 (d0b94d98c) dropped the
omarchy-hw-platformcopyomarchy-settingsshipped beside its platform guard. Its00-omarchy-hooks.confnow asks the runtime's own detector onPATH, and keeps the busybox line where there is none.The aarch64
omarchy-settingsandomarchy-settings-devrecipes still refuse a source whose baseline namesomarchy-hw-platformwithout that copy, so every aarch64 build of quattro fails once #13362 merges. This removes that check. The copy is still installed when a source ships the guard, as before.tests/settings-boot-config.sh: the #13362 fixture follows the PR's current baseline, and the split-layout test checks the package builds from it and ships no copy. The "refuses #13362's hooks without the platform detector" case is gone.pkgrelbumps (omarchy-settings5,omarchy-settings-dev2) in their own commit, because the build planner only builds a recipe whose version changed (as in omarchy-settings: keep the Limine and mkinitcpio drop-ins on aarch64 #380 and omarchy-settings: ship the full set on aarch64 for runtime-profile sources #638). The packages' contents are unchanged, so drop that commit if republishing identical packages isn't wanted.Safe to merge before or with #13362: quattro without #13362 ships no
00-omarchy-hooks.conf, so nothing it builds changes.Test plan
tests/settings-boot-config.shin a cleanubuntu:24.04container: 11 pass, 0 fail (master: 12 pass; one case removed)makepkgof both recipes for aarch64 against #13362's head (69d80cccd) on an M1 Pro: both build; the package carries the PR's baseline and no libalpm detector copy (before this change both refused)base systemd ... asahi ... sd-encryptfrom the runtime's detector and boots