Repository navigation
Fix timezone first-run notification --exec - #296
Closed
scottjones wants to merge 2 commits into
Closed
scottjones wants to merge 2 commits into
scottjones wants to merge 2 commits into
Conversation
omarchy-notification-send rejects a quoted command string, so the UTC toast never appeared after an ISO install (wifi.sh already unquotes).
Member
|
#362 carries the same fix plus focused coverage. Please close this as superseded and keep the tested PR as the merge path. |
Member
|
Superseded by #377 (same timezone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On a Mac,
install.shdoes not runomarchy_prompt_timezone(that lives on the x86 ISO /omarchy-provision-ownerform). The Mac path isinstall/user/first-run/timezone.sh: a critical notification iftimedatectlis still UTC.omarchy-notification-sendtakes--exec <program> [args...]as separate words. This leaf quoted the whole command as one string, so the send failed (exit 1), the toast never appeared, and first-run loggedprompt for the timezoneas failed.wifi.shalready unquotes--exec.After an ISO install we reproduced that exact log line on a UTC machine.
Change
The ISO installer now also asks timezone at copy time (parity with the x86 form). This PR is the first-run fallback when that did not run or the machine is still UTC.