Repository navigation
Expose config macros as Bazel config flags - #1001
Merged
Merged
Conversation
rdong8
marked this pull request as ready for review
September 13, 2026 00:04
Collaborator
|
I removed the analysis test suite to keep the repository simpler and avoid maintaining duplicate flag/default lists for tests we currently don’t plan to run in CI, rest looks good, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Bazel, to configure quill using these macros, you'd either have to:
build ---cxxopt=-DQUILL_NO_EXCEPTIONSin your .bazelrc, which propagates the define to all C++ targets. Not ideal since it causes workspace-wide cache invalidation, pollutes your compile database, etc.cc_binary(name = "my_app", deps = ["@quill"], copts = ["-DQUILL_NO_EXCEPTIONS"]). Not ideal since you have to add this to each of your own targets and ensure they are kept in sync with each otherThis PR fixes this by adding Bazel config attributes:
This was made with the help of an LLM.