Skip to content

Expose config macros as Bazel config flags - #1001

Merged
apozzer305 merged 4 commits into
odygrd:masterfrom
rdong8:bazel-configuration
Sep 13, 2026
Merged

apozzer305 merged 4 commits into
odygrd:masterfrom
rdong8:bazel-configuration

Conversation

@rdong8

@rdong8 rdong8 commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

In Bazel, to configure quill using these macros, you'd either have to:

  • Add build ---cxxopt=-DQUILL_NO_EXCEPTIONS in your .bazelrc, which propagates the define to all C++ targets. Not ideal since it causes workspace-wide cache invalidation, pollutes your compile database, etc.
  • Use cc_binary(name = "my_app", deps = ["@quill"], copts = ["-DQUILL_NO_EXCEPTIONS"]). Not ideal since you have to add this to each of your own targets and ensure they are kept in sync with each other

This PR fixes this by adding Bazel config attributes:

build --@quill//:no_exceptions

This was made with the help of an LLM.

@rdong8 rdong8 changed the title Expose config macros as Bazel configs Expose config macros as Bazel config flags Sep 12, 2026
@rdong8
rdong8 marked this pull request as ready for review September 13, 2026 00:04
@apozzer305

Copy link
Copy Markdown
Collaborator

I removed the analysis test suite to keep the repository simpler and avoid maintaining duplicate flag/default lists for tests we currently don’t plan to run in CI, rest looks good, thanks

@apozzer305
apozzer305 merged commit f31fd52 into odygrd:master Sep 13, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants