feat: Refactor CLI commands to support JSON output and improve reporting#653
Merged
Conversation
- Introduced `CmdOutput` trait for consistent output formatting across commands. - Added `OutputFormat` enum to handle human-readable and JSON output. - Updated `ConfigCmd`, `ContractsCmd`, `CallCmd`, `PrintEventsCmd`, `InspectCmd`, `StatusCmd`, `TransferCmd`, and `WhoamiCmd` to implement `CmdOutput` and return structured reports. - Enhanced `StatusCmd` to report on registered and unregistered contracts. - Refactored event logging in `CallCmd` to collect events for JSON output. - Created `TransferReport`, `WhoamiReport`, `EventsReport`, and `ContractsSchemaReport` for structured command outputs. - Added JSON serialization for command outputs using `serde`. - Updated command execution methods to return structured output instead of void.
…ract storage handling feat(status): enhance status reporting with file existence and entry count feat(repl): add dynamic status line to REPL prompt reflecting current session state
) * Refactor CasperClient to use Tokio runtime for synchronous methods - Added `reqwest-eventsource` dependency to support event streaming. - Removed unnecessary Tokio runtime instances from `LivenetContractEnv` and `LivenetHost`. - Updated `CasperClient` to manage a single Tokio runtime, allowing synchronous methods to block on async calls. - Refactored transaction watching and event handling to improve performance and readability. - Simplified event matching logic by removing the SSE parser and directly processing events. - Adjusted various methods in `CasperClient` and `TransactionWatcher` to utilize the new runtime structure. - Ensured all async methods are now properly awaited in their synchronous counterparts. * fmt
zie1ony
approved these changes
Jun 25, 2026
Benchmark report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CmdOutputtrait for consistent output formatting across commands.OutputFormatenum to handle human-readable and JSON output.ConfigCmd,ContractsCmd,CallCmd,PrintEventsCmd,InspectCmd,StatusCmd,TransferCmd, andWhoamiCmdto implementCmdOutputand return structured reports.StatusCmdto report on registered and unregistered contracts.CallCmdto collect events for JSON output.TransferReport,WhoamiReport,EventsReport, andContractsSchemaReportfor structured command outputs.serde.