dalio - Technical Training by dalio-odoo · Pull Request #1233 · odoo/tutorials

dalio-odoo · 2026-04-21T12:00:52Z

No description provided.

robodoo · 2026-04-21T12:00:55Z

Mathilde411

Very solid PR.
Also be careful of usage of ' vs ". You should use a convention and stick to it.
Most R&D teams use ' :)

Mathilde411

Very good, I don't have a lot to say :D

Mathilde411

Good job !
Fix those last few things and you'll be good to go !

Mathilde411 · 2026-04-30T08:11:57Z

+    expected_price = fields.Monetary(currency_field="currency_id", required=True)
+    selling_price = fields.Monetary(currency_field="currency_id", readonly=True, copy=False)


Default currency_field should already be currency_id here, so no need to add it

Mathilde411 · 2026-04-30T08:21:51Z

+    @api.ondelete(at_uninstall=False)
+    def _check_state_before_deletion(self):
+        for record in self:
+            if record.state not in ["new", "canceled"]:


Thre is a typo on "cancelled" here, won't work

Mathilde411 · 2026-04-30T08:23:03Z

+    def action_sold(self):
+        for record in self:
+            if record.state == "cancelled":
+                raise UserError("Canceled properties cannot be sold.")
+            record.state = "sold"
+        return True


Suggested change

def action_sold(self):

for record in self:

if record.state == "cancelled":

raise UserError("Canceled properties cannot be sold.")

record.state = "sold"

return True

def action_sold(self):

for record in self:

if record.state == "cancelled":

raise UserError("Canceled properties cannot be sold.")

self.state = "sold"

return True

Only one assignation for the whole recordset

Mathilde411 · 2026-04-30T08:23:16Z

+    def action_cancel(self):
+        for record in self:
+            if record.state == "sold":
+                raise UserError("Sold properties cannot be canceled.")
+            record.state = "cancelled"
+        return True


Same as above

Mathilde411 · 2026-04-30T08:23:38Z

+
+    price = fields.Monetary(currency_field="currency_id")
+    status = fields.Selection(
+        string="Status",


String not necessary

Mathilde411 · 2026-04-30T08:30:05Z

+    @api.model
+    def create(self, vals_list):
+
+        for vals in vals_list:
+            prop = self.env["estate.property"].browse(vals.get("property_id"))
+            existing_prices = prop.offer_ids.mapped("price")
+
+            if existing_prices and vals.get("price") < max(existing_prices):
+                raise UserError(f"The offer must be higher than {max(existing_prices):.2f}")
+
+            prop.state = "offer_received"
+
+        return super().create(vals_list)


Browse in a loop is a performance killer it should never happen. Basically if you have a recordset of all the properties and you fetch a field for one of them, the ORM is going to fetch it for all and cache them so that next iteration of the loop, you have them ready. But there since you have a different recordset for every iteration of the loop, the ORM can't do this optimization and you'll end up with one request per iteration which is very not good.

Suggested change

@api.model

def create(self, vals_list):

for vals in vals_list:

prop = self.env["estate.property"].browse(vals.get("property_id"))

existing_prices = prop.offer_ids.mapped("price")

if existing_prices and vals.get("price") < max(existing_prices):

raise UserError(f"The offer must be higher than {max(existing_prices):.2f}")

prop.state = "offer_received"

return super().create(vals_list)

@api.model

def create(self, vals_list):

#do a search/browse here

for vals in vals_list: # <- etract it by **zip**ing the vals_list with the recordset :)

existing_prices = prop.offer_ids.mapped("price")

if existing_prices and vals.get("price") < max(existing_prices):

raise UserError(f"The offer must be higher than {max(existing_prices):.2f}")

prop.state = "offer_received"

return super().create(vals_list)

Mathilde411 · 2026-04-30T08:31:21Z

+
+    _name = "estate.property.type"
+    _description = "Property Type"
+    _order = "name"


You added a sequence to order the stages but the order here was not updated

Mathilde411 · 2026-04-30T08:31:49Z

+    _order = "name"
+
+    name = fields.Char(required=True)
+    sequence = fields.Integer('Sequence', default=1, help="Used to order stages. Lower is better.")


String not needed

Mathilde411 · 2026-04-30T08:32:08Z

+    property_ids = fields.One2many("estate.property", "property_type_id", string="Properties")
+    offer_ids = fields.One2many("estate.property.offer", "property_type_id", string="Offers")
+
+    offer_count = fields.Integer(compute="_compute_offer_count", string="Offer Count")


String not needed

Mathilde411 · 2026-04-30T08:36:52Z

+        "account",
+    ],
+    "data": [],
+    "application": False,


Application's default is False, you don't need it.

My first squash commit

This commit is here to introduce the testing framework of Odoo. Try running the tests using `--test-tags :TestEstateProperty`. Doc: https://www.odoo.com/documentation/18.0/developer/reference/backend/testing.html?highlight=tests#invocation The tests were made such that the first one should work but the second one should fail. Your job is to ensure both tests pass in the end. You should update the behaviour of the appropriate models. If you want, you can also add a small test of your own to get a feel for it.

[REF] Internal: test setup dalio

3c4ec5c

Mathilde411 self-requested a review April 21, 2026 13:30

dalio-odoo added 4 commits April 22, 2026 10:58

[ADD] estate: add model

46f010c

[ADD] estate: add estate_property

2a943c1

[FIX] estate: fix style

25b1b95

[ADD] estate: add access right for estate_property

d9454fb

dalio-odoo force-pushed the 19.0-technical-training-dalio branch from 6d29bbd to d9454fb Compare April 22, 2026 09:00

dalio-odoo added 2 commits April 22, 2026 11:19

[FIX] estate: add author and license to manifest

c767015

[ADD] estate: add menus, actions and property fields logic

4faa6cd

Mathilde411 requested changes Apr 22, 2026

View reviewed changes

dalio-odoo added 6 commits April 22, 2026 16:42

[IMP] estate: add search features and apply style and security fixes

c626a8c

[ADD] estate: add types and tags

f0442fb

[ADD] estate: add offers to properties

4ac7f31

[ADD] estate: add computed fields and onchanges

3bd3578

[ADD] estate: add 'Sold' and 'Canceled' buttons

7061f54

[ADD] estate: add business logic with buttons and constraints

a3ebbc7

Mathilde411 requested changes Apr 24, 2026

View reviewed changes

[IMP] estate: Change prices to monetary fields.

ae62f85

dalio-odoo force-pushed the 19.0-technical-training-dalio branch from 2409a9d to 1338c5c Compare April 27, 2026 14:05

Mathilde411 requested changes Apr 30, 2026

View reviewed changes

dalio-odoo and others added 9 commits April 30, 2026 11:05

[IMP] estate: improve property type view and refactor code standards

5aea6e1

My first squash commit

[IMP] estate: improve UI with editable lists and stat buttons

64b4e23

[FIX] estate: add readonly to invisible status field in offer list

6a5844e

[FIX] estate: remove redundant invisible field

67c3197

[ADD] estate: add business logic for offers and extend user view

6649480

[ADD] estate_account: automate invoices creation on sold properties

9939864

[IMP] estate_account: improve syntax

6f8b1c7

[FIX] estate: add missing garden information in test

a161bf9

dalio-odoo added 2 commits April 30, 2026 11:06

[ADD] estate: add grouped kanban view for properties

04e2c19

[FIX] estate: fix business logic to ensure all tests are passed

e5ac3b6

dalio-odoo force-pushed the 19.0-technical-training-dalio branch from 5b2c1b2 to e5ac3b6 Compare April 30, 2026 09:22

dalio-odoo added 3 commits April 30, 2026 11:47

[ADD] awsome_owl: add counters, counters' sum, cards and todo lists

83a6497

[IMP] estate: apply suggestions for performance and constraints

11820f7

[ADD] awesome_owl: add counters in cards

24f482b

		expected_price = fields.Monetary(currency_field="currency_id", required=True)
		selling_price = fields.Monetary(currency_field="currency_id", readonly=True, copy=False)

Conversation

dalio-odoo commented Apr 21, 2026

Uh oh!

robodoo commented Apr 21, 2026

Uh oh!

Mathilde411 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mathilde411 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mathilde411 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants