Skip to content

add support for camino Utf8Path and Utf8PathBuf#91

Open
sunshowers wants to merge 2 commits into
oconnor663:masterfrom
sunshowers:camino
Open

add support for camino Utf8Path and Utf8PathBuf#91
sunshowers wants to merge 2 commits into
oconnor663:masterfrom
sunshowers:camino

Conversation

@sunshowers

Copy link
Copy Markdown

Add support behind a non-default "camino" feature.

Closes #90.

(One question I have is whether the feature should be called camino or camino1. I personally prefer baking in the semver major version into the feature name but opinions vary.)

@sunshowers

Copy link
Copy Markdown
Author

Should I also change the github config to run on PRs?

@oconnor663

Copy link
Copy Markdown
Owner

Should I also change the github config to run on PRs?

Oh that's a good idea, yes please.

Comment thread src/lib.rs
Allows testing for changes as they happen.
Add support behind a non-default `"camino"` feature.

Closes oconnor663#90.
@sunshowers

Copy link
Copy Markdown
Author

Updated! Sorry about the delay, this looks good to go now (hopefully tests pass)

@oconnor663

Copy link
Copy Markdown
Owner

(Apologies, I've had a busy time at work and built up a backlog of reviews on personal projects. But I haven't forgotten about this!)

@gibfahn

gibfahn commented Mar 1, 2023

Copy link
Copy Markdown

This is maybe obvious, but until we have this feature, the workaround is to use .as_str() on the path, e.g.:

let echo = Utf8Path::new("/bin/echo");

cmd!(echo.as_str(), "hi").run().unwrap();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

impl IntoExecutablePath for camino paths?

3 participants