Conversation
niquepa
marked this pull request as draft
November 8, 2023 01:17
- belongs_to optional - relationship optional - conflict with roles relationship, rolify already defines it - Had to remove the "active" condition, rolify only supports HABTM and rails 6 throws an error when the relationship is defined twice - Rolify upgrade to 5.3.0 - Use Arel.sql to avoid dangerous arguments
…passed to gritter notifier (this change goes in conjunction with issue SIMS2-4882 which ends up passing the class_name parameter value to gritter)
refactor: remove conditional statements for the class_name parameter …
… create conflicts
…ect-users-to-the-sims-login-page-after-session-timeout feat(SIMS2-5279): Add omniauthable to TransamCore, when added to SIMS…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.