Skip to content

biome: use schema output#483

Open
Eveeifyeve wants to merge 2 commits into
numtide:mainfrom
DigitalBrewStudios:biome-use-schema-output
Open

biome: use schema output#483
Eveeifyeve wants to merge 2 commits into
numtide:mainfrom
DigitalBrewStudios:biome-use-schema-output

Conversation

@Eveeifyeve

@Eveeifyeve Eveeifyeve commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pr uses the schema output that was introduced in: NixOS/nixpkgs#476453 instead of fetchurl.
I also updated nixpkgs in flake.lock due to it being outdated and not working if it's not there.

The development of this feature was supported by DigitalBrewStudios.

Closes: #511

jfly
jfly reviewed Mar 4, 2026
View reviewed changes

@jfly jfly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks. I just don't know what our policy is around how far backwards compatible we strive to be with nixpkgs.

Has NixOS/nixpkgs#476453 been backported to nixos 25.11?

Comment thread programs/biome.nix Outdated
@Eveeifyeve

Eveeifyeve commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

Very nice, thanks. I just don't know what our policy is around how far backwards compatible we strive to be with nixpkgs.

Has NixOS/nixpkgs#476453 been backported to nixos 25.11?

It hasn't, but i don't mind if you go ahead and backport it.

@jfly

jfly commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

It hasn't, but i don't mind if you go ahead and backport it.

@brianmcgee, if @Eveeifyeve's PR adding the schema output were backported to nixos 25.11, would this PR be acceptable for merging? Or would we rather wait longer than that?

@Eveeifyeve

Eveeifyeve commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

It hasn't, but i don't mind if you go ahead and backport it.

@brianmcgee, if @Eveeifyeve's PR adding the schema output were backported to nixos 25.11, would this PR be acceptable for merging? Or would we rather wait longer than that?

I am just going to backport this anyways, it doesn't hurt to NixOS/nixpkgs#496781

@Eveeifyeve Eveeifyeve force-pushed the biome-use-schema-output branch from 5fac1d4 to 972e814 Compare April 25, 2026 19:23
jfly
jfly reviewed Apr 26, 2026
View reviewed changes
Comment thread programs/biome.nix Outdated
@Eveeifyeve Eveeifyeve force-pushed the biome-use-schema-output branch from 972e814 to fcb5df1 Compare May 2, 2026 20:17
jfly
jfly approved these changes May 3, 2026
View reviewed changes

@jfly jfly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this myself, but the changes look good to me. Thanks!

@Eveeifyeve Eveeifyeve force-pushed the biome-use-schema-output branch from fcb5df1 to 5ef9b80 Compare May 15, 2026 12:54
@Eveeifyeve Eveeifyeve changed the title Biome use schema output biome: use schema output May 15, 2026
@Eveeifyeve

Eveeifyeve commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Should still be okay to merge this as many of the errors in ci are due to the x86_64-darwin deprecation of certain packages.

@jfly jfly mentioned this pull request Jun 4, 2026
Closed
@Eveeifyeve

Eveeifyeve commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@jfly can we please get a merge on this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jfly jfly jfly approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use the schema.json from the biome package for schema validation

2 participants

@Eveeifyeve @jfly