docs: add ADR 0001 (ecosystem trust, upstream contribution, fork stewardship) - #24
Merged
tonythethompson merged 2 commits intoJul 2, 2026
Merged
Conversation
…ardship) Formalizes how Numan handles third-party plugins, modules, scripts, completions, and nupm-discovered packages across all sources (official registry, custom registries, nupm) -- not just the curated official registry. Evaluated against the current codebase before writing this up, not transcribed blind: - Confirmed the "Registry Trust Requirements" section describes already-implemented behavior (RegistryManager's atomic index promote + last-known-good fallback in src/core/registry.rs), not a new ask. Recorded that explicitly so this ADR doesn't read as a TODO where the work is done. - Confirmed no contradiction with existing CLAUDE.md invariants (install is inert, activate is the only Nu-touching command, Ed25519 signatures, mandatory plugin SHA-256, lockfile snapshots). - Confirmed the package-status taxonomy here is orthogonal to, not a duplicate of, docs/nupm-compatibility.md's NupmOutcome taxonomy -- one is "can we import this nupm package," the other is "what's our trust/maintenance relationship with its origin." Added a cross-reference in nupm-compatibility.md so the two don't get conflated by a future reader. - Confirmed the inspect/audit/provenance UX and metadata schema are genuinely new work -- no such commands exist in src/cmd/ today. - Cited nushell/nu_scripts#1265 (opened this session, fixing a broken seed-package candidate upstream instead of forking it) as a live example of Lane 1 already working in practice. Status: Proposed. Implementation priorities in the ADR sequence the metadata schema, inspect/audit UX, and patch/fork workflows as separate follow-up work, not part of this change.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a proposed Architecture Decision Record (ADR) documenting Numan’s policy for ecosystem trust, upstream contribution, and fork stewardship across package sources, and cross-references it from the existing nupm compatibility contract to clarify that the two documents cover orthogonal concerns.
Changes:
- Add ADR 0001 describing package trust/maintenance status classes and decision lanes (upstream vs patch vs fork vs unsupported).
- Update
docs/nupm-compatibility.mdwith a short cross-reference clarifying thatNupmOutcometaxonomy is separate from ADR trust/maintenance status.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/nupm-compatibility.md | Adds a cross-reference clarifying how the nupm compatibility taxonomy relates to ADR 0001. |
| docs/adr/0001-ecosystem-trust-upstream-contribution-fork-stewardship.md | Introduces ADR 0001 documenting ecosystem trust and fork stewardship policy. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30101f2455
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Anthony Thompson <tonythethompson@hotmail.com>
tonythethompson
deleted the
adr-ecosystem-trust-upstream-fork-stewardship
branch
July 11, 2026 05:46
This was referenced Jul 29, 2026
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Formalizes how Numan handles third-party plugins, modules, scripts, completions, and nupm-discovered packages -- across all sources (official registry, custom registries, nupm), not just the curated official registry.
Evaluation before writing this up
RegistryManager's atomic index promote + last-known-good fallback already exists insrc/core/registry.rs. Noted this explicitly in the ADR so it reads as a recorded requirement, not an open TODO.CLAUDE.md's Critical Rules (install is inert, activate is the only Nu-touching command, Ed25519 signatures, mandatory plugin SHA-256, lockfile snapshots).docs/nupm-compatibility.md'sNupmOutcometaxonomy -- one answers "can we import this nupm package," the other answers "what's our trust/maintenance relationship with its origin." Added a cross-reference innupm-compatibility.mdso a future reader doesn't conflate the two.inspect/audit/provenanceUX and metadata schema are genuinely new work -- no such commands exist insrc/cmd/today (info.rsis the closest analog).Status
Proposed. The ADR's own Implementation Priorities section sequences the metadata schema,
inspect/auditUX, and compat-patch/fork workflows as separate follow-up work -- none of that is part of this change.Test plan