Skip to content

Fix abbreviation output for predicate mismatches - #247

Open
FranciscoMaxwell wants to merge 1 commit into
nubank:masterfrom
FranciscoMaxwell:fix-abbreviation-predicate-mismatch
Open

FranciscoMaxwell wants to merge 1 commit into
nubank:masterfrom
FranciscoMaxwell:fix-abbreviation-predicate-mismatch

Conversation

@FranciscoMaxwell

Copy link
Copy Markdown

Summary

Closes #234.

Testing

  • deps.exe -M:dev:clj-test .repro-234.clj with a temporary local runner: confirmed the matcher-combinators.config/*use-abbreviation* throws error when actual doesn't match #234 reproduction returns a printable string without throwing
  • deps.exe -M:dev:clj-test -e "(require 'matcher-combinators.config-test) (println :loaded)"
  • deps.exe -A:dev:clj-test:test-runner -n matcher-combinators.config-test was also attempted; the new regression ran, but existing assertions in that namespace fail on Windows because printer/as-string returns CRLF (\r\n) while the expected strings use LF (\n)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

matcher-combinators.config/*use-abbreviation* throws error when actual doesn't match

1 participant