Repository navigation
fix: clearer bad-usage errors for match? stubs - #243
Open
felipeofdev-ai wants to merge 1 commit into
Open
felipeofdev-ai wants to merge 1 commit into
felipeofdev-ai wants to merge 1 commit into
Conversation
Throw IllegalArgumentException with an explicit must-be-used-inside-is message, and fix docstring typos (withing/excpetion/thrown-with-match?). Fixes nubank#206 Signed-off-by: Felipe Fernandes <felipe.of.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
match?/thrown-match?/ friends now throwIllegalArgumentExceptionwith a clearmust be used inside of clojure.test/ismessage when invoked outsideis.withing,excpetion,thrown-with-match?arity docs).Why
Outside
is, users previously saw either opaque assert errors or confusing unresolved-symbol failures depending on how they referred the stubs. Issue #206 asked for descriptive bad-usage stubs.Fixes #206
Test plan
— Felipe Fernandes · Systems & Agentic AI Engineer
https://github.com/felipeofdev-ai · https://felipeofdev-ai.github.io/
Made with Cursor