Repository navigation
fix: allow absent inside any-of for missing map keys - #242
Open
felipeofdev-ai wants to merge 1 commit into
Open
felipeofdev-ai wants to merge 1 commit into
felipeofdev-ai wants to merge 1 commit into
Conversation
When absent is nested in any-of, map matching passes ::missing for a missing key. Treat that as a successful absence match. Fixes nubank#211 Signed-off-by: Felipe Fernandes <felipe.of.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Absentto match the map-matching::missingsentinel soany-of+absentworks for missing keys.Why
Bare
absentis special-cased inmatch-kv, but nestedabsent(e.g. insideany-of) went through-match, which always failed — so{:a (any-of 'b absent)}never matched a map without:a.Fixes #211
Test plan
clojure -A:dev:clj-test:test-runner -n matcher-combinators.matchers-test(0 failures)— Felipe Fernandes · Systems & Agentic AI Engineer
https://github.com/felipeofdev-ai · https://felipeofdev-ai.github.io/
Made with Cursor