Skip to content

Keep fatal signal handlers minimal to avoid hangs when another thread aborts or faults. - #1155

Merged
fafhrd91 merged 1 commit into
mainfrom
panic-handler
Oct 27, 2026
Merged

fafhrd91 merged 1 commit into
mainfrom
panic-handler

Conversation

@fafhrd91

Copy link
Copy Markdown
Member

Forward best-effort server shutdown notifications through a nonblocking pipe instead of capturing backtraces or updating the signal queue in the handler.

@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.82828% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.64%. Comparing base (4a2899d) to head (23fe70f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ntex-rt/src/signals.rs 81.11% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
+ Coverage   97.63%   97.64%   +0.01%     
==========================================
  Files         298      298              
  Lines       72641    72794     +153     
==========================================
+ Hits        70921    71082     +161     
+ Misses       1720     1712       -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… aborts or faults.

Forward best-effort server shutdown notifications through a nonblocking
pipe instead of capturing backtraces or updating the signal queue in the handler.
@fafhrd91
fafhrd91 merged commit 50c8734 into main Oct 27, 2026
34 checks passed
@fafhrd91
fafhrd91 deleted the panic-handler branch October 27, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant