Skip to content

Fix builds with the ws feature disabled - #1153

Merged
fafhrd91 merged 1 commit into
mainfrom
fix/no-ws-test-helpers
Oct 26, 2026
Merged

fafhrd91 merged 1 commit into
mainfrom
fix/no-ws-test-helpers

Conversation

@0xle0ne

@0xle0ne 0xle0ne commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Building ntex with default-features = false and features = ["tokio", "openssl"] fails because the exported HTTP and web test helpers construct WsClientConfig even though the ws module is disabled. This also prevents downstream HTTP/SSE-only applications from compiling.

Gate the three WebSocket client configurations, the WebSocket-only web test-server field and header import, and the existing handshake-error unit test behind ws. With WebSockets enabled, configuration order, addresses, timeouts and test assertions are unchanged.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 13:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.63%. Comparing base (2668d2e) to head (2aff9b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
- Coverage   97.63%   97.63%   -0.01%     
==========================================
  Files         296      296              
  Lines       72186    72187       +1     
==========================================
  Hits        70481    70481              
- Misses       1705     1706       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xle0ne
0xle0ne requested a review from fafhrd91 October 26, 2026 17:13
@fafhrd91
fafhrd91 merged commit 64e3d86 into main Oct 26, 2026
36 checks passed
@fafhrd91
fafhrd91 deleted the fix/no-ws-test-helpers branch October 26, 2026 20:40
@fafhrd91

Copy link
Copy Markdown
Member

thanks, i will make new release later this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants