perf(windows): reduce fs::metadata calls when adding a watch - #987
Merged
Merged
Conversation
Co-authored-by: 翠 <green@sapphi.red>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Windows,
watch_innerchecks that the path is a file or a directory before sending the request to the watcher thread, andadd_watchthen performs the exact same check again, plus one moreis_dircall to decide between file and directory watching. Eachis_dir/is_filecall is a separatefs::metadatasyscall, so a single watch request ends up doing up to five of them.This PR removes the duplicated client-side check and reuses one
metadataresult inadd_watch, reducing it to a single call. This mainly matters for applications that watch many individual files. As a side effect, the error for a non-existent path now includes the path, since it is reported by the watcher thread.Ported from the rolldown fork: rolldown/notify@d44e327.
Additional review notes
Part of the same effort as #980: upstreaming small changes from the rolldown fork.
Related Issues
None.