inotify,kqueue: extract test_event_loop helpers - #982
Merged
Conversation
Both backends' tests built their event loop inline, five times each. The repetition is noise in every test that follows, and it means a later change to how a test event loop is constructed has to be made ten times. Extract one helper per backend. No behavior change. Signed-off-by: Daan De Meyer <daan@amutable.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both backends' tests built their event loop inline, five times each. The
repetition is noise in every test that follows, and it means a later
change to how a test event loop is constructed has to be made ten times.
Extract one helper per backend. No behavior change.
Signed-off-by: Daan De Meyer daan@amutable.com